Comments (2)
Can we re-discuss this issue just to make sure that it is legit to add an exception?
- With types, if
strictNullChecks
is disabled, the rule never triggers becauseT
is analogous toT
|null
|undefined
in this case - With types, if
strictNullChecks
is enabled, the rule never triggers because the compiler would not accept a variable of typeT
to be assignednull
orundefined
rendering the comparison body not reachable anyway - Without types and without JSDoc annotations, the rule is never triggered because
T
is analogous toT
|null
|undefined
in this case - With JSDoc annotations, the rule is triggered when the JSDoc-declared type does not intersect with
null
, when compared tonull,
orundefined
when compared toundefined
. Hence, in this case, the issue comes from an incorrect JSDoc annotation instead of a rule false positive (for example, about https://peach.aws-prd.sonarsource.com/issues?resolved=false&rules=javascript%3AS3403&open=AYpEPL6JA8vuoRjT2MwJ, see https://github.com/WordPress/gutenberg/blob/trunk/packages/rich-text/src/types.ts) - With pure JavaScript - no
tsconfig.json
file, the rule is never triggered.
from sonarjs.
Migrated to Jira. New ticket number: JS-36
from sonarjs.
Related Issues (20)
- update all (easy) dependencies and evaluate upgrading hard ones
- Create artifact which embeds Node.JS for Alpine Linux HOT 1
- FP S6827: Thymeleaf `th:text` attribute is not recognized as a content HOT 1
- Do not count LOCs for CSS files indexed as test files
- Exclude assignment expressions to `require()` from copy-paste detection HOT 1
- javascript/S6654.html is missing `Of` in references to prototype getter/setter methods of Object
- Fix FP S6754 (`hook-use-state`): Ignore state variables without a setter
- Fix FP S2699 (`assertions-in-tests`): Add support for `supertest` HOT 1
- Fix FP S6747 (`no-unknown-property`): Don't raise for `css` attribute HOT 1
- Fix FP S6747 (`no-unknown-property`): Don't raise for allowed attributes HOT 1
- Fix FP S6747 (`no-unknown-property`): Don't raise issues from `eslint-plugin-react/no-unknown-property` when react is not used HOT 1
- Embedded Node.js runtime: detect the host architecture correctly in MacOS JRE Intel virtualization HOT 1
- Fix FP S6754 (`hook-use-state`): Add exception when using `useState` for components HOT 1
- Embedded Node.js: when `sonar.nodejs.forceHost` is set, do not deploy the runtime HOT 1
- Remove usage of deprecated logging APIs
- JS-18 S6819 False Positive when using SAP UI5 React components HOT 1
- Use 18.17.0 as minimum version for Node.JS
- Ignore runtime errors when saving cpd tokens
- Incorrect S6757 Error for Class Components HOT 8
- We should skip the whole file when we fail to save CPD token
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sonarjs.