Filter inputs fire off excessive requests to backend when gaining focus about smart_listing

[bkd]

e.g, tab browse between pages, as soon as the page with the filter gains focus and the filter has focus the request is sent again...

[dja]

+1 It's actually firing on every keypress, as well as on focus. Can we change this to only be on keyup for characters, ignoring things like arrow key presses, using control, command, or shift keys etc.?

cc: @ljachymczyk

[dja]

@bkd I forked it and made some changes to accommodate this, would be great to get others feedback:
https://github.com/danieljacobarcher/smart_listing

[bkd]

Nice work Daniel

[dja]

@bkd Just created a PR #66 with it included. Do you mind testing to make sure all is good?

[bkd]

Nice work, cant wait to get back to the home to test it out after my day's
work. seems like you have most of it solved

On Wed, May 6, 2015 at 6:22 AM, Daniel Jacob Archer <
[email protected]> wrote:

@bkd https://github.com/bkd Just created a PR #66
#66 with it included.

—
Reply to this email directly or view it on GitHub
#41 (comment).

[mahendhar9]

Hello. I too want to fix this issue in my app. Is there a quick fix for now?
Thanks

[bkd]

Yes did u check the forked versions
On 17 Jun 2016 6:39 p.m., "Mahendhar" [email protected] wrote:

Hello. I too want to fix this issue in my app. Is there a quick fix for
now?
Thanks

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#41 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAIlZzekbWq7KcFuptr80Doc8UQK3553ks5qMnlvgaJpZM4DKNgt
.

[bkd]

Check Daniel Archers repo
On 17 Jun 2016 6:39 p.m., "Mahendhar" [email protected] wrote:

Hello. I too want to fix this issue in my app. Is there a quick fix for
now?
Thanks

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#41 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAIlZzekbWq7KcFuptr80Doc8UQK3553ks5qMnlvgaJpZM4DKNgt
.

[mahendhar9]

Thank you @bkd

[ljachymczyk]

@dja Please create separate PR with changes related only to this issue.