Coder Social home page Coder Social logo

Comments (7)

elia avatar elia commented on June 1, 2024 1

you can reduce the number of commands to:

bin/rake -C admin tailwindcss:build
bin/dev

We could also touch or build the css file as part of the sandbox script, just to avoid that nasty error, but bin/dev would still be the preferred way.

All of that should be better documented once we finalize #5595, sorry about the inconvenience.

from solidus.

tvdeyen avatar tvdeyen commented on June 1, 2024

You need to run

bin/dev

but even with this the solidus_admin/tailwind.css does not get build in the admin/app/assets/builds folder.

@elia what are the steps to set up a working sandbox locally with solidus_admin. And how do the compiled assets end up in the engine folder in the released gem? Do we have a build step somewhere?

from solidus.

tvdeyen avatar tvdeyen commented on June 1, 2024

I can confirm that solidus_admin/tailwind.css is in the built gem, but it is missing in the git checkout. What makes sense, but still I cannot see a task that builds the file during release.

from solidus.

tvdeyen avatar tvdeyen commented on June 1, 2024

Workaround:

  1. CD into admin
  2. Run bundle exec rake tailwindcss:build
  3. CD into sandbox
  4. start bin/dev

@elia ideally we would have a top level rake task for this or check in the tailwind.css file into the repo, because it wont change often. Then rebuild it via GH actions on push or something (as we do in Alchemy to build our admin bundles)

from solidus.

mamhoff avatar mamhoff commented on June 1, 2024

I think this should be automated, and part of the solidus installer (at least). Also, I think this affects all extensions in the ecosystem, as none that I looked at over the past couple of days (and I looked at a few) currently build. Even the ones that should build fail with errors related to SolidusAdmin.

from solidus.

tvdeyen avatar tvdeyen commented on June 1, 2024

@mamhoff @elia now that #5600 has been merged most extensions should build again, right?

from solidus.

tvdeyen avatar tvdeyen commented on June 1, 2024

@elia what do you think about committing the built tailwind css file into the admin repo (and update it on PR merge)? That file won't change much (at least once the admin has been built out). And even in until then it makes to have it updated regularly (not just on gem release). Thoughts?

from solidus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.