Comments (5)
lxsmnsyc
commented on July 28, 2024
2
Made a PR: #65
from vite-plugin-solid.
mosheduminer
commented on July 28, 2024
1
I suspect this is a bug with this line https://github.com/solidjs/vite-plugin-solid/blob/master/src/index.ts#L256, which checks if the type is "object", but null can still pass that check, the plugin probably just needs an extra check to test whether the value is null.
from vite-plugin-solid.
Marvosg
commented on July 28, 2024
1
@mosheduminer Thank you for the help! I will attempt to add a null check there, and report back.
from vite-plugin-solid.
Marvosg
commented on July 28, 2024
@lxsmnsyc Can confirm this fixes the issue.
Thanks to both of you for your help!
from vite-plugin-solid.
ryansolid
commented on July 28, 2024
Ok this should be fixed in 2.3.10
from vite-plugin-solid.
Related Issues (20)
- 'Error: No known conditions for "./node" specifier in "msw" package' when using MSW with Vitest HOT 3
- Upgrade compatibility with Vite 5 HOT 3
- alias normalization breaks config
- Not working with happy-dom
- 2.8.1 vite dev server : Uncaught ReferenceError: _tmpl$ is not defined HOT 6
- Interpolation syntax error causes unhelpful "Invalid raw" error
- scope.registerDeclaration(declarationPath) error with vite-plugin-solid 2.8.2 HOT 6
- peerDependencyMeta in package.json should be peerDependenciesMeta
- vite-plugin-solid v2.8.3+ causes: `TypeError: Cannot read properties of undefined (reading 'extend')`
- missing changelog / release tags HOT 1
- optimizeDeps.include will produce the React version of the jsx result HOT 1
- I updated `vite-plugin-solid` and now namespaces merged with components are no longer allowed HOT 11
- Unable to pass signal to child components HOT 5
- Breaking updating from v2.9.1 from v2.10.0 HOT 1
- Should omitNestedClosingTags be actually required? HOT 1
- HMR not work in "solid-ts" template HOT 1
- Vite does not load proper build (server) on ssr webworker build HOT 4
- feature: SWC support
- Put packge into `@solidjs` namespace
- Vitest fails with TypeError: Unknown file extension ".jsx" HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vite-plugin-solid.