Comments (4)
To be fair the props object itself being optional probably not terribly common, but I could see some deeper object having this issue. But yeah.. the whole expression doesn't get processed it looks like. Compiler issue. Thanks.
from solid.
Yeah I didn't realise that I probably don't need the optional chaining there? But some error message made me add it in my code (adding it made the error go away) and then refs stopped working which sent me on another debugging journey I would have preferred to not be on
from solid.
I think I narrowed where the bug is but I don't know how to fix it:
t.isLVal(value.expression)
return true for props.ref but false for props?.ref
t.isOptionalMemberExpression return true for props?.ref but if I try to pass it in the if statement it bugs with
Property left of AssignmentExpression expected node to be of a type ["LVal"] but instead got "OptionalMemberExpression"
I don't know anything about babel so I'm not sure how to transform a OptionalMemberExpression in MemberExpression
from solid.
pretty close.
props?.ref
isn't a LHS value i.e. we can't do props?.ref = node
unlike member expr props.ref
. same for props.a?.b
, hello()
, cond ? c : d
, or any expression that isn't literal or member can potentially return a function so the correct transform is
const $ref = props?.ref
typeof $ref === 'function' && use($ref, node)
from solid.
Related Issues (20)
- Cannot use istanbul ignore comments for generated code HOT 2
- setting element reference in `setStore` modifies the values in the array HOT 13
- `this` inside jsx-template inside a constructor of a derived class causes transformation-bug HOT 2
- The update of props is not granular enough. HOT 4
- No value attribute on CSR, but present in SSR
- Cannot properly bind numbers to Select HOT 1
- Double mounting for children element. HOT 2
- Is [email protected] active now? HOT 2
- Enhancement - Prop destructuring HOT 4
- [SSR/Astro] DOM Not Updated from State by Client Updates onMount HOT 5
- Boolean attributes HOT 1
- Component doesn't reliably respond to a signal after hydration HOT 3
- JSX does not wait for transitions to complete when using a ternary in a prop value HOT 4
- What is the minimum browser support for SolidJS? HOT 2
- TypeScript doesn't give error when calling a SetStoreFunction<T> where T is an array of objects HOT 13
- SyntaxError: The requested module 'node:events' does not provide an export named 'addAbortListener' HOT 4
- When `createResource` is used to load entities, and `createStore` is used to reference those entities, updates to store properties which reference entities should not mutate the original resource.
- Attempted import error HOT 1
- Using enableScheduling in a simple solidjs-router project throws errors on transitions HOT 1
- [Bug?]: <noscript> content renders on the client HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solid.