Coder Social home page Coder Social logo

Comments (3)

vijaykiran avatar vijaykiran commented on August 28, 2024 1

In the current setup.py (Noet: tests exclusion is not really needed because they're not packages with __init__.py)

>>> find_packages(exclude=["tests"])
['sodasql', 'sodasql.cli', 'sodasql.scan', 'sodasql.common', 'sodasql.soda_server_client', 'sodasql.dialects', 'sodasql.scan.validity']

Yes, it can be done with setuptools as follows after deleting empty __init__.py files:

soda-sql on  main [$✘] via 🐍 v3.8.5 (venv385)
❯ gst
On branch main
Your branch is up to date with 'origin/main'.

Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
        deleted:    sodasql/cli/__init__.py
        deleted:    sodasql/common/__init__.py
        deleted:    sodasql/dialects/__init__.py
        deleted:    sodasql/scan/__init__.py
        deleted:    sodasql/soda_server_client/__init__.py
>>> find_namespace_packages(include=["sodasql*"])
['sodasql', 'sodasql.cli', 'sodasql.scan', 'sodasql.common', 'sodasql.soda_server_client', 'sodasql.dialects', 'sodasql.scan.validity']

from soda-sql.

dirkgroenen avatar dirkgroenen commented on August 28, 2024

You sure this is also the case for the bundler? We had a bug in 2.0.0b3 last week which was caused by a missing __init__.py, which caused the module to be not included by find_packages().

from soda-sql.

vijaykiran avatar vijaykiran commented on August 28, 2024

@dirkgroenen Made a PR to makes ure that tests run after removal of __init__ files ^

from soda-sql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.