Comments (2)
Not sure if there is a simple fix for this. I'm think the parsing has to get a serious rework.
Atm, we delegate merge the parsing of the check line and then the parsing of the optional check details. When the check line is parsed, the antlr parser is straight connected to the error message logs.
I think we should decouple that. The Antlr parser logs are way worse than I expected. I think we should just do the whole antlr parsing as a single operation that fails or succeeds. And then just produce 1 error log saying that the check line is invalid without further detail.
Other thoughts on how we could fix this more simple?
from soda-core.
Merged into #1234
from soda-core.
Related Issues (20)
- duplicate_count raise exception "ORA-00933:SQL command not properly ended" due to LIMIT keyword HOT 4
- Feature request: Support for Looker Looks as data source HOT 4
- unable to use camel case postgres columns with soda contracts HOT 2
- Contract check level filters HOT 1
- On Oracle datasource discover table columns metadata and profile columns get table and column metadata fail HOT 1
- Contract quoting of schemas, datasets and columns HOT 2
- Contract API docs update HOT 3
- Add contract support for failed rows query HOT 1
- Add contract spark session API HOT 2
- Duplicate count check: on Oracle datasource wrong query to select failed rows HOT 3
- Contract identity issue HOT 5
- Issue connecting to db2 from soda-core HOT 3
- Yaml emitter error while executing scans concurrently HOT 6
- not able to install in databricks enviornment HOT 2
- Duckdb: schema metric not computed for db in file HOT 1
- Invalid configuration header: expected "data_source {data source name}" HOT 2
- Soda Core Trino 3.3.3 and 3.1.1 : Metrics 'schema' were not computed for check 'schema' HOT 2
- Spark partitioned tables HOT 2
- Issue to install soda-core-pandas-dask via Poetry in Windows HOT 2
- Migrate soda-core-athena to use newer PyAthena >= 3.0.10 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from soda-core.