Comments (2)
Also @janet-can gave input on this earlier: https://sodadata.slack.com/archives/C02J6Q493PY/p1646250277182629
For the CLI output for checks status:
why does a warning include the text Only? Only 1 warning. 0 failure. 0 error. 0 pass. If there are more than one warnings, the Only is still there: Only 2 warnings. 0 failure. 0 errors. 0 pass. Are 50 warnings still Only? 100? However, the failures trump the warnings in order of precedence so 1 failure and 2 warnings seems fine. Oops! 1 failure. 2 warnings. 0 errors. 0 pass.
Sometimes it says 0 warnings and sometimes it says No warnings— is that intentional? All is good. No failures. No warnings. No errors. Oops! 1 failure. 0 warnings. 0 errors. 0 pass.
Can we change the output message to apply plural where appropriate? Oops! 1 failures. 0 pass. 2 pass. 0 failure
Why does the word Oops! appear when there is a failure? It implies that something is wrong when, really, a failed test means that something is working correctly/as expected! Maybe instead: Note ? The Damn! for an error seems about right, tho. Oops for errors is spot on.
from soda-core.
Oh, heh, both of those are mine. I transferred my notes in Slack to a ticket in soda-sql-v3 which has now been transferred here. Good memory, @tombaeyens ! ;)
from soda-core.
Related Issues (20)
- spark/databricks execution error AttributeError: 'NoneType' object has no attribute 'sql' HOT 5
- Soda & DBT HOT 3
- Group by fields not present in scan results output HOT 2
- Migrate soda-bigquery to use newer google-cloud-bigquery HOT 4
- `sample_context` does not contain `check_name` if using a fail expression HOT 1
- Athena: Incorrect catalog column name for column metadata. HOT 1
- Fetch generated SQL queries for the checks configured in context HOT 5
- Duplicate row samples fails with dotted field name for BQ nested column (struct) HOT 1
- MS SQL Server sources table- and column handling issue HOT 2
- pandas dask tutorial warnings/errors HOT 2
- Presto as a data source HOT 2
- Review added at repo-reviews.github.io HOT 1
- Remove duckdb version constrain HOT 1
- invalid_count block other tests execution HOT 2
- OAuth connection for Trino/Starburst HOT 1
- Add prerequisite option to check configuration HOT 1
- SodaCore 3.0.48 is not compatible with Airflow 2.7 HOT 2
- Duplicate count throw TypeError if column not exist HOT 2
- Parser does not support otherwise legal table valued functions HOT 1
- [test] Testing the updated integration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from soda-core.