Cannot build TS project when targeting Node16 or NodeNext about socket.io-client

[tylerbutler]

I think the root of the problem is that the exports field for the package doesn't define types for the CJS export. I think it should look more like this:

    ".": {
      "import": {
        "types": "./build/esm/index.d.ts",
        "node": "./build/esm-debug/index.js",
        "default": "./build/esm/index.js"
      },
      "require": {
        "types": "./build/cjs/index.d.ts",
        "default": "./build/cjs/index.js"
      }
    },

https://www.typescriptlang.org/docs/handbook/modules/reference.html#packagejson-exports

I think the types need to be duplicated, too, so that the CJS and ESM types have different paths. I found this somewhere in the Typescript docs but can't find it now, so I might be mistaken.

Patching the exports field manually worked in my project; I can open a PR if it is helpful.

[tylerbutler]

This should be fixed by 605de78, included in version 4.7.3.

@tylerbutler could you please check?

Sorry for the delay. I confirmed 4.7.3 works for us, and I was able to remove our patched version. Thank you!

[darrachequesne]

Hi!

or add the field "type": "module" to '/home/jmarcou/dev/tarot-ai/package.json'.

I think you might be missing the "type": "module" in your package.json file, could you please check?

[Julien-Marcou]

Yes, it's a possible solution, but then I need to rewrite my entire project to be compatible with ESM, which is not the case at the moment.

For instance, all my imports doesn't specify the file extension, if I switch to "type": "module", then I need to fix all my imports.

Isn't socket.io-client supposed to behave as socket.io when imported on a Node.js project ?

[luisdeka]

waiting for this...

[darrachequesne]

This should be fixed by 605de78, included in version 4.7.3.

@tylerbutler could you please check?