binary in message::list results in error about socket.io-client-cpp

[nylki]

Reversing the function calls works without flaws interestingly:

    message::list argumentList(std::make_shared<std::string>(buff, buffer.size()));
    argumentList.push(string_message::create("foo2"));
    argumentList.push(string_message::create("foo3"));

I'd close this, but an explanation why my first attempt doesnt work, would be good. Furthermore it should optimally be versatile enough to allow my first attempt. :)

[vincent-raman]

I think it would have worked if you'd have done

message::list argumentList("test1");
argumentList.push(binary_message::create(std::make_sharedstd::string(buff, buffer.size())));

It only due to the fact that there are a lot of constructor defined but only one "push" method taking message::ptr as argument. We could effectively overload this method to have all the combinations available for constructors.

[nylki]

@macq-vraman ah, there is binary_message::create? Interesting! Didn't see it mentioned and didn't look thoroughly enough in the code, apparently. will try tommorow, thanks!

update (4. september):

@macq-vraman it works 👍
I am leaving this issue to the devs to close or keep open.

[jmigual]

Was this issue fixed by #64?