Hard dependency on diff-highlight from diff-so-fancy about diff-so-fancy

[stevemao]

👍 Ideally I don't wanna maintain diff-highlight. Wish we could reference that dependency from the official git repo somehow.

[paulirish]

yeah understood.
i dont know of an easy way.

I just explored trying to use diff-highlight from the machine, but i'm not sure how to do that on non-homebrew installs.

tbh, the simplest looks to be just writing a stupid script to pull the latest diff-highlight from the git repo every once in a while. it doesnt change a lot so no biggie.

[paulirish]

here's my proposal in #13

[stevemao]

Found a problem in #13 (sorry didn't see it earlier). We assume the diff_highlight path is ./third_party/diff-highlight/diff-highlight which might not be the case. npm link won't work. Documentation

Grab the two scripts (diff-highlight and diff-so-fancy) via either downloading or cloning the repo.
Place them in a location that is in your PATH.

Is incorrect.
We don't really know the path of our hard dependency diff-highlight

[stevemao]

Maybe we just use which diff-highlight?

[xixixao]

Why not just let people install and pipe themselves?

git diff --color | diff-highlight | diff-so-fancy

[stevemao]

We want to load diff-hight internally in diff-so-fancy.