Coder Social home page Coder Social logo

Comments (3)

snguyenthanh avatar snguyenthanh commented on May 13, 2024

What do you think about adding ! to char i and + to char t in the CHAR_MAPPING variable: https://github.com/snguyenthanh/better_profanity/blob/master/better_profanity/better_profanity.py#L33-L42

from better_profanity.

jcbrockschmidt avatar jcbrockschmidt commented on May 13, 2024

@snguyenthanh I think we should, yeah. That will fix the issue for these particular words.

We should also display a warning message to let the user know when a words/phrase is invalid and won't be censored.

from better_profanity.

jcbrockschmidt avatar jcbrockschmidt commented on May 13, 2024

I tried adding "!" to ALLOWED_CHARACTERS and it caused test_unicode_vietnamese_2 to fail:

FAIL: test_unicode_vietnamese_2 (__main__.ProfanityUnicodeTestVietnamese)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 176, in test_unicode_vietnamese_2
    self.assertEqual(profanity.censor(bad_text), censored_text)
AssertionError: 'Con chó sủa **** gâu!' != 'Con chó sủa **** ****!'
- Con chó sủa **** gâu!
?                  ^^^
+ Con chó sủa **** ****!
?                  ^^^^

If a swear word ends with a "!", it will be ignored when "!" is an allowed character.

Here's a unit test we can use to test punctuation:

    def test_punctuation(self):
        bad_text = "Holy shit! Oh fuck, damn. What the hell? Shut up, asshole..."
        censored_text = "Holy ****! Oh ****, ****. What the ****? Shut up, ****..."
        self.assertEqual(profanity.censor(bad_text), censored_text)

from better_profanity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.