Coder Social home page Coder Social logo

Comments (7)

smjonas avatar smjonas commented on August 22, 2024

Thanks for reporting, I'll definitely look into this!

Also an aside question, does this use the AST for renaming?

It uses Nvim's builtin LSP functions (vim.lsp.buf.rename and another to get the locations of the variables), so it depends on the concrete LSP server for the current buffer. Although probably every LSP server constructs an AST of some kind.

from inc-rename.nvim.

smjonas avatar smjonas commented on August 22, 2024

Which language server are you using? (output of :LspInfo?)

from inc-rename.nvim.

DMunkei avatar DMunkei commented on August 22, 2024

I was using Pyright and jedi-language-server.

from inc-rename.nvim.

sirwebdev avatar sirwebdev commented on August 22, 2024

Hy guys, any date to fix that issue ?? I had the same problem here using the "js/ts language server" at lazyvim

from inc-rename.nvim.

DMunkei avatar DMunkei commented on August 22, 2024

I've also had this issue constantly happening inside of TS while writing vuejs code. It somehow just deletes more than it should. Not sure why.

from inc-rename.nvim.

smjonas avatar smjonas commented on August 22, 2024

Hy guys, any date to fix that issue ?? I had the same problem here using the "js/ts language server" at lazyvim

@pmartinsdev Thanks for also reporting this issue. Can you please provide me with example code where this is happening? It's hard for me to find out what the problem is without that.

from inc-rename.nvim.

Moerliy avatar Moerliy commented on August 22, 2024

I mentioned this in #53 too.

Something I noticed and could have the same root problem:
1. Same project, same file
2. line 92 and try renaming ParseContext.
3. Add a couple of characters and have a look at the preview. With every new character added to the rename, the previously added characters should appear again with every new character you add. Hard to describe but the number of characters shown in the preview is the factorial of the number of characters added to the rename.
(not sure if you can reproduce it tho because that behavior is a bit less predictable)

You should be able to reproduce this with the second example.

from inc-rename.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.