Comments (3)
Suggestions are always welcome! I personally think this is a stylistic preference (i.e., do you prefer logic to be in the default params vs. in the function body?). To be consistent with the rest of the code, let's keep it the same for now. But we may come back to this later and convert all initialization code to default parms.
from smashtest.
Come to think of it, I like the param = 0
thing. We should do that across the board. But I think that anything complex like isSequential = (stepNode.isSequential && !(stepNode instanceof StepBlockNode))
should be in the function body.
from smashtest.
@vptes1 , Ok, I managed to refactor all functions that have variable initialization inside the function body to the function header.
from smashtest.
Related Issues (20)
- Click on multi element/multi choice HOT 2
- --screenshots=stepfail only takes a screenshot after a step fails HOT 6
- Improve speed of generating branches HOT 1
- Add Drag & Drop function HOT 1
- Safari screen shots don't show canvas elements HOT 4
- [Web] Example with syntax error? HOT 1
- #ss takes screenshot on the step it's attached to HOT 9
- Step timeout HOT 1
- Installer HOT 1
- --repeat=N to repeat failing tests
- When a Safari window is launched, sometimes it doesn't match the specified browser size HOT 3
- Feature request - ability to disable progress output
- How to override default timeout HOT 1
- Opera browser support HOT 1
- CI - DevToolsPort doesn't exist HOT 1
- Error: Server terminated early with status 1 HOT 1
- Feature request: add easy way to match inside another element HOT 2
- Using groups multiple times in Smashtest results in groups being ignored, and many branches being run HOT 2
- Consider making "next to" apply to only visible elements? HOT 1
- Please push latest code, tags, changelog to Github HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smashtest.