Comments (2)
@nicktaras There are several issues I pointed out yesterday that you have not actioned:
-
This contract address is wrong. The latest version of ETHRegistarController is 0x253553366Da8546fC250F225fe3d25d0C782303b you are using an older version and I'm not sure why it's not a payable function as renewing costs ETH. I'd updated this yesterday but you created your own branch and reverted my changes. Please take care when merging.
-
Similarly, the transaction definition is incorrect. Let's compare the 721 definition:
<ts:transaction> <ethereum:transaction function="renew" contract="ETHRegistrarController" as="uint"> <ts:data> <ts:string ref="ensName"/> <ts:uint256 local-ref="renewalSeconds"/> </ts:data> <ethereum:value local-ref="renewalPrice"/> </ethereum:transaction> </ts:transaction>
To the 1155 version:
<ts:transaction> <ethereum:transaction function="renew" contract="ETHRegistrarController" as="uint"> <ts:data> <ts:uint256 ref="baseENSTokenId"/> <ts:uint256 ref="renewalSeconds"/> </ts:data> </ethereum:transaction> </ts:transaction>
Notice that the value is missing.
from tokenscript-templates.
@nicktaras I found out that the address (0x57f1887a8BF19b14fC0dF6Fd9B2acc9Af147eA85) you were using is the base registrar not the ETHRegistrarController. The renew function for base registar is probably used internally through the ETHRegistarController.
from tokenscript-templates.
Related Issues (13)
- Spelling error for success message shown on the dialog box when accepting friend invite for ERC721 messaging. HOT 2
- Admin message input field does not clear and the message says invalid date when admin message is sent. HOT 2
- Issue when user rejects the signing requests for "Get Friends" and "Chat with Friends". HOT 4
- Accept Request button does not gets disabled after the request is accepted. HOT 2
- Chat bubbles color to differentiate between the sender and receiver. HOT 2
- Do we somehow add a refresh mechanism to load the latest chat message if the message window is open. HOT 4
- Latest sent messages are sometimes not shown at all till few more messages are sent. HOT 3
- Value shown in ETH and USD in info tab is 0. HOT 3
- "Failed to invite friend" message shown on UI even when the invite was sent successfully. HOT 4
- On Android + AlphaWallet, the signing request for session is not received. HOT 6
- On Android + Edge when clicking the send message button, sometimes the message is not sent and the input field gets scrolled to the bottom. HOT 5
- Unread messages are not being highlighted when messages are sent from wallet "0x25f81833a56d6E71e44D16f8D2E27F1e999CD29F" HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tokenscript-templates.