Coder Social home page Coder Social logo

Comments (2)

micwallace avatar micwallace commented on September 26, 2024

@nicktaras There are several issues I pointed out yesterday that you have not actioned:

  • This contract address is wrong. The latest version of ETHRegistarController is 0x253553366Da8546fC250F225fe3d25d0C782303b you are using an older version and I'm not sure why it's not a payable function as renewing costs ETH. I'd updated this yesterday but you created your own branch and reverted my changes. Please take care when merging.

  • Similarly, the transaction definition is incorrect. Let's compare the 721 definition:

    <ts:transaction>
      <ethereum:transaction function="renew" contract="ETHRegistrarController" as="uint">
      	<ts:data>
      		<ts:string ref="ensName"/>
      		<ts:uint256 local-ref="renewalSeconds"/>
      	</ts:data>
      	<ethereum:value local-ref="renewalPrice"/>
      </ethereum:transaction>
    </ts:transaction>
    

    To the 1155 version:

      <ts:transaction>
      <ethereum:transaction function="renew" contract="ETHRegistrarController" as="uint">
      	<ts:data>
      		<ts:uint256 ref="baseENSTokenId"/>
      		<ts:uint256 ref="renewalSeconds"/>
      	</ts:data>
      </ethereum:transaction>
    </ts:transaction>
    

    Notice that the value is missing.

from tokenscript-templates.

micwallace avatar micwallace commented on September 26, 2024

@nicktaras I found out that the address (0x57f1887a8BF19b14fC0dF6Fd9B2acc9Af147eA85) you were using is the base registrar not the ETHRegistrarController. The renew function for base registar is probably used internally through the ETHRegistarController.

from tokenscript-templates.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.