vacations: Error raised due to temporary error at name resolution about plugins

[psilo909]

any idea how to "provoce" it, so I could test that?

[bmxp]

Not really. I think it might have to do with an Update of the FritzBox and a network that is not available then. At least the error description is fine for me and understandable but this is not a code error at all, it just does not look nice to see the Traceback here

[Morg42]

If I understand the plugin code correctly, this error originates in the imported ferien-api module. It could be try/except-ed by enclosing the ferien call, but this doesn't really seem sensible.
If this should really be taken care of, I'd suggest opening an issue with ferien-api...

[msinn]

Will something happen with this issue or should it be ignored/closed?

[Morg42]

The current develop plugin has a try/except brace around the API call, so this error should not occur anymore.

Exception handling was added after the issue was opened, but seemingly for other reasons - so the error might have been fixed "by accident" ;-)

[psilo909]

@Morg42 perhaps you are right, perhaps i also added it after reading the issue and forgot to comment. I am not sure if it really fixed all of the problem - but on my side it never occurred

[psilo909]

@Morg42 also the master has the try except https://github.com/smarthomeNG/plugins/blob/master/vacations/__init__.py#L68

So I am not sure if this really catches everything. In theory it should.

[msinn]

SmartHomeNG v1.9.4 has been released