Coder Social home page Coder Social logo

Comments (12)

onkelandy avatar onkelandy commented on July 25, 2024

Umgebaute Squeezebox und lirc funktionieren bei mit seit Wochen ohne Probleme.

from plugins.

Morg42 avatar Morg42 commented on July 25, 2024

Plugin network is finished and runs completely on lib.network.
Plugin cli is adapted and will be provided together with the new lib.network.
Plugins lirc, knx, squeezebox don't need updates and work out of the box.

from plugins.

Morg42 avatar Morg42 commented on July 25, 2024

All modified and awaiting testing in https://github.com/Morg42/plugins/tree/network/, necessary lib.network in https://github.com/Morg42/smarthome/tree/libnetwork/

from plugins.

bmxp avatar bmxp commented on July 25, 2024

Maybe we should wait until the next release 1.8 which is prepared by @msinn for January
until the efforts of @Morg42 are pushed into develop?
This way we can get a more thorough test in develop instead of pulling from the private repo.

from plugins.

Morg42 avatar Morg42 commented on July 25, 2024

That was my suggestion to @msinn already. Much as I'd like to see lib.network in 1.8, more testing and completion of plugin seems sensible.

from plugins.

msinn avatar msinn commented on July 25, 2024

That's why I added the milestone 1.9 before your comments.

from plugins.

Morg42 avatar Morg42 commented on July 25, 2024

All lib and plugin code is integrated and running. References to lib.connection are removed in plugins; for core files, this is provided in PR smarthome/#402.

The last remaining point is actually removing lib.connection from the core.

This should probably be done earliest for 1.10, so privately used plugins can be adjusted.

Does this need some kind of deprecated-warning?

from plugins.

bmxp avatar bmxp commented on July 25, 2024

Yes, we should give a warning with each usage of lib.connection IMHO. @msinn did a great job with other deprecated warnings within the code.
The only fear I have is that some users won't get the deprecated warning due to misconfigured logging setup.

from plugins.

Morg42 avatar Morg42 commented on July 25, 2024

The warning "system" might be upgraded to show a all-pages warning on the Admin UI.

On the other hand, we can't make sure to reach everyone. A best-effort approach should be enough on evolving OSS. As long as some users don't update their systems, nothing is going to happen anyway. I guess you can expect someone upgrading to read the release notes, or the readme?

from plugins.

bmxp avatar bmxp commented on July 25, 2024

If I've learned anything important in my life then the most important lesson is the one that people don't read anything until something goes wrong. And if this is the case, then they blame the docu that it was not presented in an understandable way.
Most people would easily sign their own death warrant ...

from plugins.

Morg42 avatar Morg42 commented on July 25, 2024

I'm painfully aware. But not doing anything is not an option...

from plugins.

Morg42 avatar Morg42 commented on July 25, 2024

Closing this issue as the plugin modification is complete.

The core issue is resumed at issue 410 @smarthome

from plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.