Comments (11)
I do agree that it makes sense to align with what we're adding in capabilities, which is health-cards
. I'm also thinking we can drop the "VC" part because we're issuing health cards, which are VCs. What I like with the existing proposal is the implicit namespacing using the period, so something like $health-cards.issue
seems preferable to me.
from health-cards.
Please respond to this comment with a thumbs-up if you'd like to rename $HealthWallet.issueVc
to $health-cards-issue
.
- Feel free to add another comment with an alternative proposal (try to keep the comment brief/narrow so we can interpret reactions).
- Vote thumbs-up on as many proposals as you like (i.e., anything you'd be happy with)
from health-cards.
Keep the current name $HealthWallet.issueVc
from health-cards.
Does FHIR have explicit conventions for naming OperationDefinitions? I see some jurisdiction specific guidance like https://developer.nhs.uk/apis/fhir-policy/naming.html#FHIR-NAME-05 (which uses a mix of capital and lower case letters, for what it's worth) but not universal guidance.
In the examples you listed, the common pattern is verb-noun
(e.g., find-matches
, submit-data
, collect-data
), but this is mostly the case when they apply directly to a FHIR resource e.g., Measure/$submit-data
), but your proposal is noun-verb
-- it's only superficially aligned with the syntax of the FHIR examples.
I'm not sure it's helpful to break current implementations by renaming this operation, especially if there's no ecosystem-wide convention that we'd be aligning to.
from health-cards.
I found it here: https://confluence.hl7.org/display/FHIR/Guide+to+Designing+Resources:
be lowerCamelCase for elements, UpperCamelCase for resources, be lowercase for operations
from health-cards.
This guidance applies to core FHIR content; it doesn't say much about operations beyond lower-case (as you point out), and different jurisdictions have set different rules. I see a clear cost associated with changing the name of $HealthWallet.issueVc
, and I don't see a benefit. Can you clarify the goals of renaming?
from health-cards.
I agree that there is a cost associated to renaming the operation but if we do decide to rename it, do we need consider "HealthCard" instead of "HealthWallet". The wallet naming has been dropped everywhere except the operation name.
from health-cards.
My goal is keep consistency with FHIR core naming convention. A possible naming would be $issue-healthcard. I assume another operation missing (for future development) is $verify-healthcard (section https://smarthealth.cards/#presenting-health-cards-to-a-verifier). I am sure what the "cost" is.
from health-cards.
My goal is keep consistency with FHIR core naming convention.
Given that Health Cards is not part of FHIR core, the value is unclear here. The cost is breaking existing implementations that folks have been working on; if we're going to do so, now is certainly the time! (The cost will only grow.)
Keep in mind that the operation "Grouping" structure ("HealthWallet") is also used in SMART capability discovery; if we changed the operation name, we'd want to change the capability name too.
I very much wouldn't want to make the "common part" a suffix; it should be a prefix, to make the grouping function clear.
@zsura I do agree with your point about the word "wallet". If we were going to rename this operation, I guess I'd want to call it health-cards-issue-vc
. Let me try a straw poll; I'll add a follow-up comment with a precise question.
from health-cards.
healthcard-issuevc
from health-cards.
$health-cards.issue has the most votes but doesn't meet Yunwei's syntax requirement which kicked off this issue in the first place. I'll go forward with $health-cards-issue
from health-cards.
Related Issues (20)
- Clarification re multiple QR codes HOT 15
- Request change to use only NIST IAL Levels 1, 2, and 3. HOT 2
- Publish reference implementation of card parser HOT 2
- Java implementation of Jws HOT 1
- specify version 22 HOT 8
- Examples are not generating HOT 3
- Error related to generationg certificates HOT 4
- QR code FAQ link broken HOT 3
- Governance needs to be clarified HOT 2
- Release Tagging lax
- Create new github release matching spec's changelog version HOT 3
- Golang "swiss army knife" for smart health cards HOT 2
- Optional exp field to be honoured by verifiers HOT 2
- Can I get clarification on the section "Every Health Card can be embedded in a QR code" HOT 1
- Clarification of computation of `rid` HOT 3
- Clarification on how to encode a QR code HOT 1
- Clarification of examples/allowable data HOT 4
- Document sample certificate-generating script HOT 1
- Rationale for inclusion of kid in recommended revocation id generation scheme HOT 5
- Response code 404 (Not Found) HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from health-cards.