When the latest versions of esp-hal and slint are present simultaneously, a compilation error occurs about slint

[Song-aff]

esp-rs/esp-hal#1434 (comment)
I also raised this question in ESP-HAL

[ogoffart]

Looks like we shouldn't unconditionally require critical-section in

slint/internal/core/Cargo.toml

Line 58 in a61ca93

portable-atomic = { version = "1", features = ["critical-section"] }

and maybe also in once_cell, but we then need to enable it in some case. I wonder what's best here.

[KortanZ]

Any plan to fix this? It's really annoying that need to patch esp-hal as a workaround in order to use slint. Really thankful if this could be fixed 🙂.

[ogoffart]

Not sure how to fix this.
We can't just remove the features = ["critical-section"] from our Cargo.toml, otherwise things will stop compiling.
Even if we add unsafe-single-threaded = ["portable-atomic/unsafe-assume-single-core"] in our own Cargo.toml this won't work on stm32

[KortanZ]

@ogoffart what if we follow the portable-atomic crate recommendation? Leave the end user to determine which feature to use, features = ["critical-section"] or features = ["unsafe-assume-single-core"]. We remove features = ["critical-section"], and add an slint feature let's say critical-section, and bind portable-atomic/critical-section. Full change may like:

unsafe-single-threaded = ["portable-atomic/unsafe-assume-single-core"]
critical-section = ["portable-atomic/critical-section"]

And user could choose one of them to use.

Update:
There may some HAL use critical-seciton in protable-atomic, but user may still need use unsafe-single-threaded in slint. So we may need change like:

unsafe-single-threaded = []
portable-atomic-single-core = ["portable-atomic/unsafe-assume-single-core"]
portable-atomic-critical-section = ["portable-atomic/critical-section"]

A breaking and clumsy change, but I can't see any other solution. : (

[ogoffart]

I guess you're right. We can make it non-breaking by using the compat-1-2 feature.

In api/rs/slint/Cargo.toml

unsafe-single-threaded = []
portable-atomic-single-core = ["portable-atomic/unsafe-assume-single-core"]
portable-atomic-critical-section = ["portable-atomic/critical-section"]
compat-1-2 = ["portable-atomic-critical-section", "compat-1-7"]
compat-1-7 = []

in internal/core/Cargo.toml

portable-atomic = { version = "1", features = ["require-cas"] }

But we also need to document that properly.

(This just makes it even more complicated to setup for MCU apps)