Syntax Highlighting is broken :( about vim-slim

[DAddYE]

+1 !!!!

[darthdeus]

Could you provide a sample where it doesn't work? I'm using it on the master branch in a quite large project and it works fine for me.

If you're talking about embedding another syntax in slim, such as ruby/javascript/coffeescript, those were intentionally removed from the plugin for pure performance reasons in #22. You can checkout ec1f885 if you need the additional syntaxes.

But at least from my perspective, it's not really a good practice to have a lot of embedded languages in your HTML templates, if that's the case.

@darthdeus an example for this behavior would be this file. It looks some kind of broken and weird if you use the latest git version of vim-slim.

[darthdeus]

@Poapfel it works fine for me for the example you gave (saved via :TOhtml)

[DAddYE]

As u can see it stopped to highlight HTML tags

Sent from my iPhone

On 17/ott/2012, at 10:05, Jakub Arnold [email protected] wrote:

@Poapfel https://github.com/Poapfel it works fine for me for the example
you gave https://dl.dropbox.com/u/2896872/layout.slim.html (saved via
:TOhtml)

—
Reply to this email directly or view it on
GitHubhttps://github.com/bbommarito/vim-slim/issues/23#issuecomment-9535206.

[darthdeus]

This is basically partial revert of the performance tweaks I did in #22, caused by deleting haml syntax, which is somehow used for tag highlighting if I understand this correctly.

But some attributes, like data-foo are still not highlighted properly ... I'm going to take a look at it some more.

But some attributes, like data-foo are still not highlighted properly ... I'm going to take a look at it some more.

Those weren't highlighted before your changes.

[DAddYE]

I'm okay with performance, but now anything is highlighted. Can we revert
back and then figure a better approach to this?! Maybe setting a variable
in vimrc ?

Sent from my iPhone

On 17/ott/2012, at 12:14, Poapfel [email protected] wrote:

But some attributes, like data-foo are still not highlighted properly ...
I'm going to take a look at it some more.

Those weren't highlighted before your commits too.

—
Reply to this email directly or view it on
GitHubhttps://github.com/bbommarito/vim-slim/issues/23#issuecomment-9539990.

[darthdeus]

@DAddYE It has the same syntax highlighting as in the initial commit, so there's nothing really to revert.

As far as I know the data-foo comes from default HTML highlighting, so I'm not sure how to change that. But I might be wrong on that one.

[DAddYE]

mmm, yep because before it uses the haml syntax, now without that any html tag is not highlighted. In this case we can use plain text which is the same no ?

[DAddYE]

for those how want back the old syntax highlighting https://github.com/DAddYE/vim-slim

[maletor]

+1 this is broken from #22.