Allow pure Ruby attribute values about slim

[stonean]

So, to summarize, an attribute without quotes means the attribute's value is set by a method call. I like it, less typing!

[judofyr]

Or a local variable. Or foo[:hello] etc. You can think about it as the Hash syntax:

name="hello" # => { :name => "hello" } 
name=hello   # => { :name => hello }

[fredwu]

There is a slight catch - We already allow custom delimiters on attributes. For example:

meta(name="#{something}" value="#{anotherthing}")

Having another set of delimiters, while not conflicting with the attributes delimiter, might cause confusion to the end users.

meta(name=(1 + 1) value=(another("evaluated", :ruby => "method")))

Although, one might argue that it's to the end users to determine the best use for delimiters. :)

Just a thought.

[fredwu]

Ah, disregard my last comment, I haven't seen ticket #16 when I replied.

[stonean]

Here's what I think should be allowed for attributes:

/ standard
meta name="keywords" value="slim, template"  

/ interpolation, standard Ruby stuff inside
meta name="keywords" value="#{page_keywords}"

/ no quotes = method call
meta name="keywords" value=page_keywords

/ no_quotes = method call with params
/ we won't evaluate these, so valid Ruby code is required
/ just as if it were being called in a String
meta name="keywords" value=page_keywords(params[:action])

I don't think we should allow for the use case:
meta name=(1 + 1)

The delimiters issue ( #16 ), should only apply to enclosing the attributes of a tag. I like the quote/no quote cleanliness for the attributes. So options should be:

meta name="keywords" value=page_keywords
meta(name="keywords" value=page_keywords)
meta[name="keywords" value=page_keywords]
meta{name="keywords" value=page_keywords}

Let's face it, attributes are typically quoted, so interpolation should be the common option. I think it will be more of a pain to have the method calls return quoted strings than to just use interpolation.

[activestylus]

While we are on this subject, I'm wondering how this haml example would translate to Slim:

div{:class => params[:active] ? "active" : "inactive"}

I've tried plain string interpolation:

div(class="#{params[:active] ? "active" : "inactive"}")

syntax error, unexpected $undefined, expecting '}'
...menu(class="#{params[:active]">? "active" : "inactive"}")<...

I know, I know, logic almost always belongs in a helper, but these one-line conditionals are a life saver sometimes.

[stonean]

This is what you'd want:

class="#{ ( params[:active] ? "active" : "inactive" ) }" 

I added the spaces for clarity

[fredwu]

Just a quick note: I'm working on this ticket.

[activestylus]

Thanks stonean, that did it - I assume that eventually we will just do this, seeing as interpolation is overkill here?

class=( params[:active] ? "active" : "inactive" )

[fredwu]

Allows pure ruby attribute values. Closed by a0ed999

The code is a bit cryptic for now, will refactor soon.