Coder Social home page Coder Social logo

Comments (5)

AlecHaring avatar AlecHaring commented on June 16, 2024 1

It seems like even after your fix, this issue is still not fully fixed. res.Header.Get(k) only returns the first value of the given key. I'll open a PR with a fix

from burp-awesome-tls.

sleeyax avatar sleeyax commented on June 16, 2024

Good catch, thanks. We can't do something like res.Header.Write(w) because that would write the headers to the body instead of actually setting the HTTP headers in the response. Or what did you have in mind to shorten this, exactly? Suggestions are welcome.

from burp-awesome-tls.

sleeyax avatar sleeyax commented on June 16, 2024

Replaced Set with Add. Though if you have another approach/improvement, let me know or create a PR to include it in the next release.

from burp-awesome-tls.

AlecHaring avatar AlecHaring commented on June 16, 2024

Or what did you have in mind to shorten this, exactly?

I was thinking we could call res.Header.Clone() and then swap the instance of the ResponseWriter w/ the cloned Header, but it does not look like there's a clean way to do it

from burp-awesome-tls.

sleeyax avatar sleeyax commented on June 16, 2024

Closed in #18

from burp-awesome-tls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.