Comments (4)
🙋♂ I'd like to tackle this
from readder.
@andreasvirkus yeah, I remember having the same issues back when I installed the dependencies for the first time, even in Mojave. I don't remember what I did to solve them finally but right now I have node v10.16.3, so that might be the answer hahaha
As of the code it's looking great so far! I'd definitely advice to either call the CHANGE_THEME mutation directly or adding an optional parameter to the current SWITCH_THEME since this will come in handy if we finally decide to implement some kind of persistence; talking of which, I briefly mentioned it in #16, so it's definitely up to you, if you prefer you can work on this feature on its own and then add some persistence in another branch that we can reuse to start implementing the settings or do it all in this PR and we can continue from here once we decide to start working on the settings. The same for localStorage or a cookie! 😋
Thanks for the great work!
from readder.
🙋♂ I'd like to tackle this
@andreasvirkus great to hear! If you have any doubts or want to discuss any technical detail feel free to mention it here 😃
Sent with GitHawk
from readder.
I had a hard time getting the dependencies to install locally (on MacOS Catalina) because of some infamous node-gyp
errors 😞 (with Node v12.11.1
)... I might just have to downgrade my Node verson to 8.*
something, as some issues under the node-gyp
library suggest :/
I started working on the code nonetheless - That's what I've added so far - https://github.com/andreasvirkus/readder/blob/feature/theme-preferences/src/view/App.vue#L33-L60
(I'll most likely also add a state param to the switchTheme
action instead of creating separate actions per theme? So if no param is passed in, it'll act as a toggle (current functionality))
We can use window.matchMedia
to initially check for the preference as well as add a listener so it's reactive to any changes that happen while the user is on the site!
Btw, I saw that the theme choice is not persisted atm between site visits - would it be OK to save it in localStorage (or a cookie, up to you) for example? If yes, can I do it within this same issue or would you like it to be a separate PR?
from readder.
Related Issues (17)
- Filter posts with no content HOT 1
- Notify errors and empty results to the user HOT 4
- Add the ability to select the post sorting option
- Change the community input to allow specifying other communities aside from Reddit and show auto completion HOT 1
- Improve margins in the Reader component HOT 1
- Make the app responsive
- Add support for external links HOT 6
- How to contribute HOT 1
- Refactor to make it easier to add other communities HOT 1
- Add support for DEV.to articles HOT 1
- Fix community suggestions to ignore capitalization
- Subreddit/tag link redirects to _blank HOT 1
- Allow the user to navigate between compatible articles in the reader HOT 5
- Add a settings page HOT 2
- Give more priority to longer posts
- Add community custom sorts and filters
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from readder.