Local GCP service account prevents private GCS bucket being used in file_mounts about skypilot

[Michaelvll]

Seems the error can be fixed by avoiding uploading the credential files when the service account is used, i.e. check if GCP._get_identity_type() == GCPIdentityType.SERVICE_ACCOUNT, return an empty dict in file mounts:

skypilot/sky/clouds/gcp.py

Lines 763 to 782 in 0696eba

	def get_credential_file_mounts(self) -> Dict[str, str]:
	# Excluding the symlink to the python executable created by the gcp
	# credential, which causes problem for ray up multiple nodes, tracked
	# in #494, #496, #483.
	# We only add the existing credential files. It should be safe to ignore
	# the missing files, as we successfully created the VM at this point,
	# meaning the authentication is successful.
	credentials = {
	f'~/.config/gcloud/{filename}': f'~/.config/gcloud/{filename}'
	for filename in _CREDENTIAL_FILES
	if os.path.exists(os.path.expanduser(
	f'~/.config/gcloud/{filename}'))
	}
	application_key_path = self._find_application_key_path()
	if os.path.exists(os.path.expanduser(application_key_path)):
	# Upload the application key path to the default path, so that
	# autostop and GCS can be accessed on the remote cluster.
	credentials[DEFAULT_GCP_APPLICATION_CREDENTIAL_PATH] = (
	application_key_path)
	return credentials

[concretevitamin]

An attempted fix that uploads ~/.config/gcloud/legacy_credentials/<currently active account> subdir rather than the whole ~/.config/gcloud/legacy_credentials/ dir: c1ea4ed