skylobby-skylobby.desktop about skylobby

[skynet-gh]

Updated with hopefully better keywords 49c04b4

[skynet-gh]

OK I figured out how to override the default .desktop file for .deb and .rpm packages, so categories and keywords are set in latest.

[skynet-gh]

@narcisgarcia sounds good, do you want to open a PR for this?

[narcisgarcia]

I've just installed skylobby-0.7.21_linux-amd64.deb and it does not come with this update.

[narcisgarcia]

I've just installed skylobby-0.7.22_linux-amd64.deb and /opt/skylobby/lib/skylobby-skylobby.desktop does not come with this update.

[skynet-gh]

Ah, meant to respond here before, I didn't realize you were using the .deb. That package is limited to what `jpackage´ supports, and so doesn't use this ´.desktop´, The package that uses it is https://aur.archlinux.org/packages/skylobby-git/

[narcisgarcia]

$ sudo dpkg -i skylobby-0.7.22_linux-amd64.deb

$ dpkg -L skylobby | grep -e '\.desktop$'
/opt/skylobby/lib/runtime/legal/java.desktop
/opt/skylobby/lib/runtime/legal/jdk.unsupported.desktop
/opt/skylobby/lib/skylobby-skylobby.desktop

$ cat /opt/skylobby/lib/skylobby-skylobby.desktop
[Desktop Entry]
Name=skylobby
Comment=skylobby
Exec=/opt/skylobby/bin/skylobby
Icon=/opt/skylobby/lib/skylobby.png
Terminal=false
Type=Application
Categories=Unknown
MimeType=application/sdfz

[skynet-gh]

Looks like one that's auto generated by jpackage?

[narcisgarcia]

I didn't run package generation and I don't know options for openjdk/jpackage; I can't answer your question.

[narcisgarcia]

Current with Skylobby 0.7.39 package:

$ dpkg -L skylobby | grep -e '\.desktop$'
/opt/skylobby/lib/runtime/legal/java.desktop
/opt/skylobby/lib/runtime/legal/jdk.unsupported.desktop
/opt/skylobby/lib/skylobby-skylobby-console.desktop
/opt/skylobby/lib/skylobby-skylobby-highmem.desktop
/opt/skylobby/lib/skylobby-skylobby-lowmem.desktop
/opt/skylobby/lib/skylobby-skylobby-vhighmem.desktop
/opt/skylobby/lib/skylobby-skylobby-vlowmem.desktop
/opt/skylobby/lib/skylobby-skylobby-web-console.desktop
/opt/skylobby/lib/skylobby-skylobby-web.desktop
/opt/skylobby/lib/skylobby-skylobby.desktop
/opt/skylobby/lib/skylobby-skyreplays.desktop

At least all skylobby*.desktop files are installed at desktop menu, but only skylobby-skylobby.desktop seems to be needed for desktop UI.

[skynet-gh]

@narcisgarcia those are all from jpackage, which I don't have much control over.

Linux packaging in general needs work, but unfortunately it seems like it will be per-package-manager or per-desktop-environment. Some users created skylobby packaging for Arch for example.

[narcisgarcia]

This issue is approved to be implemented to jpackage on JDK version 18:
https://bugs-stage.openjdk.java.net/browse/JDK-8270175

Please, maintain this issue open, pending of jpackage v18 is released on 2022/03/22 and can be used to build packages with better launchers control.

[narcisgarcia]

OpenJDK 18 enters today in General Availability stage.

[skynet-gh]

I've removed most of these launchers since they became irrelevant with ZGC.

[narcisgarcia]

Thank you!
I feel skylobby-skyreplays.desktop irrelevant too, because Skylobby it has already a [Replays] launcher at Main panel.

I still propose to change some parameters in skylobby-skylobby.desktop :

Comment=Play real-time strategy games using the Spring RTS engine
Categories=Game;StrategyGame;
Keywords=real-time;strategy;lobby;network;multiplayer;spring;

(this is to be well classified in Desktop Environments, and to be easily found with DE search actions)
https://bugs.openjdk.org/browse/JDK-8270175