support erb interpolation in skylight.yml about skylight-ruby

[jfelchner]

@carllerche any word on getting the "setting the config from an initializer" working? Currently setting the ENV in a config/initializers file doesn't work. Nor does doing a Rails.application.configure block and setting config.skylight.authentication in there in a config/initializers file.

It would be pretty great if we could set this at Rails boot time.

[carllerche]

Another option would be to configure the agent directly from the rails initializer. Something like:

config.skylight.authentication = Rails.application.secrets.skylight['authentication']

That probably would be better than the ERB route. Thoughts?

[janvarljen]

I already tried defining this in my production.rb file

config.skylight.application = Rails.application.secrets.skylight['application']
config.skylight.authentication = Rails.application.secrets.skylight['authentication']

and removed the config/skylight.yml file but it didn't work.

am I doing something wrong?

[carllerche]

Oh sorry, that currently doesn't work :) I was asking if that would be a better solution for you vs. ERB in the YAML (which I am generally not a fan of).

[janvarljen]

Oh ok. Yeah I agree that that would be a better approach.

Do you have an estimate when this will be available?

P.S. if you're interested here's how newrelic is handling reading .yml files

https://github.com/newrelic/rpm/blob/5560d8ecff0dcece53a80edbc4535cc60fc188d8/lib/new_relic/agent/configuration/yaml_source.rb

[carllerche]

No estimate yet, the easiest "work around" would be to use environment variables. It would be possible to set the environment variables in the Rails app before it boots if you don't want to set it externally.

Something like the following should work:

ENV["SKYLIGHT_AUTHENTICATION"] = Rails.application.secrets.skylight['authentication']

as long as it happens early on.

[janvarljen]

Ok thx for your comments.