Issue with AVA codemod about jest-codemods

[xjamundx]

No need to fix it for me or anything, but just a heads up.

[xjamundx]

It turns it fails even without the promise

import test from 'ava'

test('should pass', t => {
    shouldFail(t, 'hi')
})

function shouldFail(t, message) {
    t.same('error', message)
}

[skovhus]

Thank you so much for sharing the code examples here. I'll look into a fix.

Did it work for you on the rest of the codebase?

[xjamundx]

There were some issues, so like the default paths don't work. The only seem to work when I type them from the command line.

jest-codemods public/js/**/__tests__/*.js works
jest-codesmods without a path does not work (even if I type the path during the command step). It just says it can't find any of my files.

I assume that's something to do with how you process paths vs. how the OS does it for you. Anyway, not a big deal.

Also had some issues installing globally, so i was just running it locally from ./node_modules/.bin/jest-codemods

So far so good, not all the tests that transpiled are passing, but it's helping a lot

[skovhus]

Thank you for sharing, I really appreciate it! : )

Based on your example I found some issues with how t properties were parsed. It should now be more stable now. And also handle AVA t.same and other deprecated AVA properties that I overlooked. fd5e

Can you give 0.2.4 a spin?

As for the problem with global installment, which version did you try? Maybe you can try out 0.2.4 and see if you have the same problem.

Thanks!

[skovhus]

Version 0.2.5 should fix your issue with globs not working when not providing a path.

[xjamundx]

awesome! trying them now

On Fri, Sep 30, 2016 at 4:23 PM, Kenneth Skovhus [email protected]
wrote:

Version 0.2.5 should fix your issue with globs not working when not
providing a path.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#8 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPBf2j23yoP5W5UjhlAkQw8NKx7ezK-ks5qvZoFgaJpZM4KLacR
.

[skovhus]

There is still some issues with not removing t for the case where you are passing it to a function.

Example:

import test from 'ava'

test('should pass', t => {
    shouldFail(t, 'hi')
    return shouldFail2(t, 'hi')
})

function shouldFail(t, message) {
    t.same('error', message)
}

function shouldFail2(t, message) {
    return Promise.reject().catch(err => {
        t.same(err.message, message)
    })
}

Currently converts to

it('should pass', () => {
    shouldFail(t, 'hi')
    return shouldFail2(t, 'hi')
})

function shouldFail(t, message) {
    expect('error').toEqual(message)
}

function shouldFail2(t, message) {
    return Promise.reject().catch(err => {
        expect(err.message).toEqual(message)
    })
}

Notice that t is undefined. It should either be removed or replaced with Jasmines done function.

[xjamundx]

cool, this is more than enough to get us started thanks!

[skovhus]

@xjamundx let me know if you find other bugs. : )