Comments (7)
Thanks for reporting this. : )
Do you want to work on a PR for this?
from jest-codemods.
Yes I would like to give it a try 😉
from jest-codemods.
Sound good. Let me know if you need any help. : )
from jest-codemods.
src/transformers/chai-should.js:406
On this line node.type
equals Identifier
, the condition passes if node.type
equals ObjectExpression
. I want the if condition to pass so we can surround the constant with Object.keys
. Do you have a suggestion for this?
I already added tests in my fork: WebDevMichael@39dbb22
from jest-codemods.
It sounds right to me.
from jest-codemods.
How can I see if the Identifier (constant JSON object) is of the type ObjectExpression
?
Because Identifier can also be any other possible variable, i.e. an array.
from jest-codemods.
So that is the challenging part.
Short answer: you can't.
Longer answer: if the identifier is assigned inside the file you can search the AST for assignment to this specific identifier... But it might be assigned multiple places. AND the identifier might be defined in another file.
I cases like this, I do a best guess and log a warning that the transformation might not be right.
from jest-codemods.
Related Issues (20)
- jasmine-globals: Suggest relaxing matching for spyOn(..).and.xx(..) HOT 1
- Feature Suggestion: Command Line Options for Prompts HOT 1
- Chai: `not.to.include` erroneously transformed to `toEqual(expect.arrayContaining...)` HOT 2
- doesn't convert chai `to.be.equalTo` to jest `toEqual` HOT 3
- TypeError: babel.loadOptionsSync is not a function HOT 3
- Ava: test.failing should be changed to test.skip HOT 2
- Feature Suggestion: Migration from outdated versions of Jest HOT 4
- Dependency Dashboard
- Version 0.26.2 is unrunnable due to esm-only globby HOT 2
- Sinon transformer doesn't seem to recognize sinon usages HOT 2
- convert jasmine clock methods to jest
- Sinon transformer doesn't support cjs HOT 4
- Why test migration skipped?
- Feature request to migrate from intern
- Is Sinon actually incompatible with Jest?
- Does not support Typescript `satisfies` keyword HOT 2
- Typescript: function (this) is incorrectly transformed HOT 1
- `jasmine-globals`: support for `jest.setSystemTime()`
- `jest-globals-import`: false negative when global is explicitly imported
- `jasmine-globals`: async `SpyStrategy` methods are not supported
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jest-codemods.