Coder Social home page Coder Social logo

Comments (7)

SimenB avatar SimenB commented on June 12, 2024 1

IMO jest-codemod should leave those alone as test === it in Jest. People who care should use https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/consistent-test-it.md instead

from jest-codemods.

skovhus avatar skovhus commented on June 12, 2024 1

I would like to avoid too many options and have some good defaults. I think preserving what the user had makes sense.

The link was just to the main docs where test is used instead of it.

Reverting will not work as there has been to many changes since back then. But applying the changes manually should do the job. :)

from jest-codemods.

skovhus avatar skovhus commented on June 12, 2024 1

I’ll keep this open until the change is released.

from jest-codemods.

skovhus avatar skovhus commented on June 12, 2024

It was changed Jest docs advertise the usage of test instead of it: http://facebook.github.io/jest/docs/en/api.html#testname-fn

See original issue (3 years ago): #64

But it makes sense to keep it or test if the user is using it.

Also if this is the case, is there a way of avoiding this replacement in the jest-codemods utility currently

Reverting the changes in 9c1a780 should do it. @MatthewTrout let me know if you are up for creating a PR. :)

from jest-codemods.

MatthewTrout avatar MatthewTrout commented on June 12, 2024

Thanks for the response @skovhus

It was changed Jest docs advertise the usage of test instead of it: http://facebook.github.io/jest/docs/en/api.html#testname-fn

See original issue (3 years ago): #64

Yeah I found that issue, but that anchor on the jest docs doesn't link to anything in the page so wondered if they'd changed their mind on that!

Reverting the changes in 9c1a780 should do it. @MatthewTrout let me know if you are up for creating a PR. :)

Yeah happy to do this but will simply reverting it work or will it then convert test to it? Presumably we'd like it to just not touch it or test.

from jest-codemods.

SimenB avatar SimenB commented on June 12, 2024

Could be an option I guess?

from jest-codemods.

skovhus avatar skovhus commented on June 12, 2024

Released as 0.23. Thanks for your contribution!

from jest-codemods.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.