Comments (7)
IMO jest-codemod
should leave those alone as test === it
in Jest. People who care should use https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/consistent-test-it.md instead
from jest-codemods.
I would like to avoid too many options and have some good defaults. I think preserving what the user had makes sense.
The link was just to the main docs where test is used instead of it.
Reverting will not work as there has been to many changes since back then. But applying the changes manually should do the job. :)
from jest-codemods.
I’ll keep this open until the change is released.
from jest-codemods.
It was changed Jest docs advertise the usage of test
instead of it
: http://facebook.github.io/jest/docs/en/api.html#testname-fn
See original issue (3 years ago): #64
But it makes sense to keep it
or test
if the user is using it.
Also if this is the case, is there a way of avoiding this replacement in the jest-codemods utility currently
Reverting the changes in 9c1a780 should do it. @MatthewTrout let me know if you are up for creating a PR. :)
from jest-codemods.
Thanks for the response @skovhus
It was changed Jest docs advertise the usage of
test
instead ofit
: http://facebook.github.io/jest/docs/en/api.html#testname-fnSee original issue (3 years ago): #64
Yeah I found that issue, but that anchor on the jest docs doesn't link to anything in the page so wondered if they'd changed their mind on that!
Reverting the changes in 9c1a780 should do it. @MatthewTrout let me know if you are up for creating a PR. :)
Yeah happy to do this but will simply reverting it work or will it then convert test
to it
? Presumably we'd like it to just not touch it
or test
.
from jest-codemods.
Could be an option I guess?
from jest-codemods.
Released as 0.23. Thanks for your contribution!
from jest-codemods.
Related Issues (20)
- jasmine-globals: Suggest relaxing matching for spyOn(..).and.xx(..) HOT 1
- Feature Suggestion: Command Line Options for Prompts HOT 1
- Chai: `not.to.include` erroneously transformed to `toEqual(expect.arrayContaining...)` HOT 2
- doesn't convert chai `to.be.equalTo` to jest `toEqual` HOT 3
- TypeError: babel.loadOptionsSync is not a function HOT 3
- Ava: test.failing should be changed to test.skip HOT 2
- Feature Suggestion: Migration from outdated versions of Jest HOT 4
- Dependency Dashboard
- Version 0.26.2 is unrunnable due to esm-only globby HOT 2
- Sinon transformer doesn't seem to recognize sinon usages HOT 2
- convert jasmine clock methods to jest
- Sinon transformer doesn't support cjs HOT 4
- Why test migration skipped?
- Feature request to migrate from intern
- Is Sinon actually incompatible with Jest?
- Does not support Typescript `satisfies` keyword HOT 2
- Typescript: function (this) is incorrectly transformed HOT 1
- `jasmine-globals`: support for `jest.setSystemTime()`
- `jest-globals-import`: false negative when global is explicitly imported
- `jasmine-globals`: async `SpyStrategy` methods are not supported
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jest-codemods.