Comments (16)
@olivergg really like this :)
I do believe there are actually 3 states here. Ready, Not Ready, and Unknown. Where "Not Ready" means the k8s can communicate with the server, but it's not ready yet. And "Unknown" means the server is unreachable.
Also, I think it might look a little nicer if the icons were centered horizontally. What do you think?
@mowings Currently, you can sort by the "Ready" column to place the "not ready" nodes at the top of the list (which I do a lot). Will that work for you for the short term?
from skooner.
- One could change the READY column to display some kind of a checkmark (instead of just rendering the boolean value) (would need an icon for that)
- I would change the icon in the type column to symbolize the fact that it is a master, but not the READY column which should just display the status, not the nature of the node 😉
@herbrandson I'm willing to do that if it's okay for you 😅
from skooner.
What about :
?
(I've just used two utf-8 symbols for that : U+2713 and U+1F6C7)
from skooner.
@herbrandson Yes, you're right, I thought the "Ready" state was a boolean.... I should have read the documentation https://kubernetes.io/docs/concepts/architecture/nodes/#condition 🙈
I'm not a CSS expert, but I'll try do to my best 😅
As for the sorts, one could sort by default by the "Ready" column and then by the "Name" column. Therefore, if all nodes are ready, it's the same as the current sort 😉
from skooner.
@mowings I would need more time to understand how the sort works (and to properly implement it in an idiomatic way), but for now, the #60 PR makes the things a little bit prettier;)
from skooner.
Thanks @olivergg -- I will have a look when I get a chance!
from skooner.
Just to add an additional note, at least for us it's probably more important that unready or unknown status nodes float to the top. Sorting by master or worker node is not really that big a deal here
from skooner.
Just built and deployed with @olivergg s pr. Definitely a big improvement. If the sort could float unready nodes to the top it would be perfect. Thanks again for your work!
from skooner.
Actually, it looks like the PR causes breaks the namespace pane. When navigating to the namespace pane, I get an error message. While there are no api errors, the javascript console shows:
TypeError: Cannot convert undefined or null to object
at Function.entries (<anonymous>)
at dt (listViewHelpers.js:76)
The code in question is:
{/** If the node is a master, display a simple "MASTER" label below the item.kind icon */}
{Object.entries(item.metadata.labels).some(([key, _]) => key === "node-role.kubernetes.io/master")
&& <span className='td_iconLabel node-master'>MASTER</span>}
This seems to be broken on the namespace pane. I am guessing this is because namespaces (or at least mine) don't have any labels.
EDIT: Same issue with the config pane
from skooner.
I left a comment in the PR with the fix -- you do need to check that labels actually exists, Thanxs!
from skooner.
Yikes! I missed this comment before merging that PR :(
@olivergg I ran into similar issues in various other places and as a result had started using lodash functions instead of things like Object.entries
because it deals with null/undefined values.
@mowings I saw you had another PR. Was it the patch for this issue?
from skooner.
@herbrandson thanks, I'll have a look at lodash. Meanwhile, f2ee674 was the actual fix for this missing check. Regarding the other PR, I guess, an interractive rebase should be necessary from @mowings 😉
from skooner.
@herbrandson @olivergg -- I closed out that PR and submitted a clean one just to fix the ApiVersion issue.
My master has diverged a bit from yours -- so I resubmitted from a clean branch. Should be good to go.
from skooner.
@herbrandson I've added a fix to my branch 8de135d to use lodash function ._has
from skooner.
Hey guys -- I am going to close this issue out and create another one just for the sorting unready masters to the top part.
from skooner.
Perfect. Thanks @mowings
from skooner.
Related Issues (20)
- Add support for user/group impersonation
- The install instructions are broken. HOT 6
- CVE-2021-44906
- CVE-2022-37434
- Enhancement: allow for skipping the login screen HOT 2
- OIDC authorization error: 400 bad request HOT 4
- Need to enable https in skooner HOT 4
- Where are the helm charts? HOT 8
- Up and running with oidc via Dex - metrics URLs return 403s HOT 2
- Bug: RAM Request/Limits calculation is incorrect. HOT 1
- Auth Token HOT 7
- OIDC api is failing . Due to internal error
- How to troubleshoot OIDC issues? HOT 2
- Skooner not displaying Deployments HOT 1
- Running skooner with subpath HOT 1
- Does Skooner support OIDC PKCE Auth HOT 3
- Pods: Ready vs Requested should exclude pods in Succeeded state HOT 1
- kubernetes-skooner.yaml does not declare any CPU/RAM request HOT 1
- Can Skooner base path be changed from / ? HOT 2
- Skooner erroring all of a sudden HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skooner.