Invalid sort in workload page about skooner

[olivergg]

Done #46

[kvpt]

Also the age seems wrong to me.

If you need more informations to reproduce the issue, let me know.

[herbrandson]

Hey @kvpt. I'm using an npm package for converting the date into "age" and unfortunately the letter "m" for both minutes and months :(

Does that explain what you're seeing?

[kvpt]

Oh yes you're right, the second screenshot show that.

[olivergg]

@herbrandson this library has not been updated for years now. I kinda guess you've switched from Moment.js to it for performance reason. Would you like to have a PR with another lib in k8dash or a PR in the time-ago project to merely fix the specific use case (milliseconds vs minutes vs month, all represented by 'm') ?
Btw, thanks for this amazing project k8dash ;)

[herbrandson]

I suspect the easiest route would be a pr in k8dash (which I would love!). Is there a specific library you're considering?

[olivergg]

@herbrandson what about humanize-duration ?

var humanizeDuration = require("humanize-duration")

const shortEnglishHumanizer = humanizeDuration.humanizer({
  language: 'shortEn',
  languages: {
    shortEn: {
      y: () => 'y',
      mo: () => 'mo',
      w: () => 'w',
      d: () => 'd',
      h: () => 'h',
      m: () => 'm',
      s: () => 's',
      ms: () => 'ms',
    }
  }
})
var nd = 1554401268000; // 4/4/2019
var diff = Date.now() - new Date(nd).getTime()
shortEnglishHumanizer(diff).split(",")[0]
// => "8 mo"

[herbrandson]

LGTM. Do you want to create a PR?

[olivergg]

@herbrandson Yes, I'll try to do that this week :-)

[herbrandson]

Thanks for the PR! It's been merged and this should now be resolved :)