istio crd issues about skooner

[herbrandson]

Thanks for reporting this @thpang. That is driven by checking if the status.phase is "Running". If you click on one of those pods, what is the value for "Phase"?

[thpang]

@herbrandson

Status phase for both is: Completed
Ready for both is listed as: 0/1

Let me know if you need more info.

[herbrandson]

Ok, I see. It looks like those are some sort of "init" process that runs and then completes. I assume they're a "Job" then?

I think that "Completed" tasks probably need a different icon. Maybe a "grey" color. What do you think?

[thpang]

I know in the Weave Scope application they do show them a bit differently. So grey would be good to show they have completed, but not really hurting anything in the cluster.

[herbrandson]

Hey @thpang. I've pushed an update to the :dev label in docker hub. Would you mind giving that a test and letting me know how it looks to you? Thanks!

[thpang]

So I did not test from docker hub, but tested from the dev branch in the repo. Was that updated? I did not notice any change.

[herbrandson]

It should be. You can verify by opening client/src/components/podsPanel.js. The should be a function named getPhaseStyle. If that's there, you should have the latest.

[herbrandson]

Hey @thpang. Were you ever able to verify the code you have includes that function? Is this still not working for you?

[thpang]

Eric, I have not sorry. Busy pushing out a release. I should be able to verify in a day or two or sometime over the 4th of July weekend. Thanks for checking back in. Take care, Thomas From: Eric Herbrandson <[email protected]> Reply-To: herbrandson/k8dash <[email protected]> Date: Tuesday, July 2, 2019 at 11:04 AM To: herbrandson/k8dash <[email protected]> Cc: Thomas Pangborn <[email protected]>, Mention <[email protected]> Subject: Re: [herbrandson/k8dash] istio crd issues (#29) EXTERNAL Hey @thpang<https://github.com/thpang>. Were you ever able to verify the code you have includes that function? Is this still not working for you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#29>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHYCFOW2YLPXLVKP6CHK75LP5NU7FANCNFSM4HYZGFIQ>.

[thpang]

Eric, I do see the code and it appears that they do show up now grey in some places, but still show up as an error in others. Also noticing that the icons are now a greenish color when they fail vs the redish color they were. Let me find which panel is showing the information I am talking about and let you know. Take care, Thomas From: Eric Herbrandson <[email protected]> Reply-To: herbrandson/k8dash <[email protected]> Date: Tuesday, July 2, 2019 at 11:04 AM To: herbrandson/k8dash <[email protected]> Cc: Thomas Pangborn <[email protected]>, Mention <[email protected]> Subject: Re: [herbrandson/k8dash] istio crd issues (#29) EXTERNAL Hey @thpang<https://github.com/thpang>. Were you ever able to verify the code you have includes that function? Is this still not working for you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#29>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHYCFOW2YLPXLVKP6CHK75LP5NU7FANCNFSM4HYZGFIQ>.

[herbrandson]

Thanks for the update @thpang. Yes, please let me know where you're seeing the issue and I'll take a look.