Discussion: Event changes about tcr

[kangarang]

Sorry, I didn't mean to close this so abruptly. Please feel free to comment with any feedback and I'll be happy to reopen this issue.

[kangarang]

Still need to add:

• event _ChallengeSucceeded(uint challengeID, uint rewardPool, uint totalTokens);
• event _ChallengeFailed(uint challengeID, uint rewardPool, uint totalTokens);

[eccheung4]

Nice, looks good to me.

Not sure if challenger needs to be added to _Challenge event as I get that from the sender of transaction, but not against adding it.

[kangarang]

oh yeah, good point @eccheung4 . i do that too lol

[kangarang]

@eccheung4 , any particular thoughts on the experimental change?

event _VoteRevealed(address voter, uint pollID, uint votesFor, uint votesAgainst);

[kangarang]

maybe...

event _VoteRevealed(uint pollID, uint numTokens, uint votesFor, uint votesAgainst);

since address voter we can get from tx.from

by that same logic, we can get rid of all the address voters

[kangarang]

@eccheung4

Here's another good one

Current:

event _ChallengeFailed(uint challengeID);
event _ChallengeSucceeded(uint challengeID);

Proposed:

event _ChallengeFailed(uint challengeID, uint rewardPool, uint totalTokens);
event _ChallengeSucceeded(uint challengeID, uint rewardPool, uint totalTokens);

[kangarang]

_ProposalUnprocessed(bytes32 propID);
->
_ProposalExpired(bytes32 propID);

[kangarang]

Resolved:

Registry: f5b42b2

PLCRVoting: cab98ed

Parameterizer: 6d3eac7