Coder Social home page Coder Social logo

Incomplete components: 㳽 about makemeahanzi HOT 5 CLOSED

skishore avatar skishore commented on September 26, 2024
Incomplete components: 㳽

from makemeahanzi.

Comments (5)

skishore avatar skishore commented on September 26, 2024

I think the default decomposition for 瀰 is wrong. You'll have to fix it on the analysis stage. Take a look at the current decomposition in dictionary.txt - it's "left-to-right ⿰氵彌", which is correct - the component 㳽 is wrong.

from makemeahanzi.

olivernyc avatar olivernyc commented on September 26, 2024

Here's what I see at the analysis stage:

screen shot 2018-06-04 at 1 23 39 am

Which seems correct? It looks like 㳽 is coming from the simplified character, not the component. Or maybe I'm misunderstanding something.

from makemeahanzi.

skishore avatar skishore commented on September 26, 2024

Ah, right. I must have made the simplified character a dependency of the traditional one.

For this kind of thing I typically change the code of the relevant stage, let Meteor reload the page, make the edit, then change the code back. It keeps the strictest validation working in general but relaxes it for a small number of characters where the data is wonky. (If I have to keep making the change several times, then I look into a better fix.)

In this case, the relevant line to change is here:
https://github.com/skishore/makemeahanzi/blob/tool/client/lib/analysis.js#L169

Replace it with "this.simplified = null;" to treat the character as if it were simplified already.

from makemeahanzi.

olivernyc avatar olivernyc commented on September 26, 2024

Makes sense -- I got it to work. Thanks again for the help!

from makemeahanzi.

skishore avatar skishore commented on September 26, 2024

Fixed by #41

from makemeahanzi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.