Coder Social home page Coder Social logo

Comments (14)

skishore avatar skishore commented on September 26, 2024

Thanks for the report. It's fixed here, and I'm pulling the fix into Inkstone now.

from makemeahanzi.

GrimReaperSam avatar GrimReaperSam commented on September 26, 2024

That's awesome thank you! While you're at it I found out today that this character is also drawn weirdly 餃.
However, I'm not sure what is the correct way so do you mind checking?

Cheers!

from makemeahanzi.

skishore avatar skishore commented on September 26, 2024

I'm looking at that character here: http://makemeahanzi.herokuapp.com/#/codepoint/39171

Are you referring to the way the 食 radical is written with one stroke at the end instead of two? That is a bit of an irregularity, but it's part of the open-source Arphic font that Make Me a Hanzi is based off of and I don't have a great way to edit it. There are many other characters with similar issues, particularly traditional ones.

from makemeahanzi.

GrimReaperSam avatar GrimReaperSam commented on September 26, 2024

Sorry!! I meant this one: 條.
I must've copied the wrong character up there.

from makemeahanzi.

skishore avatar skishore commented on September 26, 2024

I see! Yeah, there are two oddities with that character. First off, that "tiao" component on the right is written the traditional way. That's an artifact of the Arphic font, and difficult to fix. The direction of one of the strokes in that component is also wrong, which I've fixed in 6104c89. Thanks!

from makemeahanzi.

GrimReaperSam avatar GrimReaperSam commented on September 26, 2024

Hi,

I have a couple more characters that have weird stroke order or don't respond correctly (favoring a stroke over another).

飛 : Doesn't recognize strokes correctly in the upper part (mixes the stroke when drawing 飞)
飯 : Wrong stroke order for the right part (first stroke of 反)
盤 : Doesn't recognize strokes for top right part (very hard to draw the second stroke of 几)
覺 : first x on top wrong order, compare to 學

Thanks again for the amazing work you're doing. If I knew how to update it i'll do it myself.

from makemeahanzi.

skishore avatar skishore commented on September 26, 2024

Fixed the data for 飯 and 覺. The data for the other two is correct but the handwriting recognition algorithm could be improved, so I filed the other issue.

from makemeahanzi.

GrimReaperSam avatar GrimReaperSam commented on September 26, 2024

Hey,

Thanks, I'm waiting for the inkstone update!
If you don't mind I found a bit more inconsistencies.

對: weird stroke order with homework 作業 (Talking about the top left part)
髒: weird order for the grass character on the right
醫: top right is hard to write, guess same problem as 盤.
黑 and 點: The stroke order doesn't feel correct (maybe different between them?)

Thanks man

from makemeahanzi.

skishore avatar skishore commented on September 26, 2024

I don't see what is wrong with 對.

Fixed 髒.

That's right about 醫 - I will fix it all in one go by improving recognition for that "shu1" component. The algorithm makes use of decompositions so addressing it at that level will fix it for all characters.

Wow, you're right about 黑, and it affects a few dozen characters! However, I am not sure what the correct order is - there is conflicting information on the internet. Do you happen to have a reference for (mainland Chinese) stroke order which we could use to disambiguate?

from makemeahanzi.

GrimReaperSam avatar GrimReaperSam commented on September 26, 2024

I'll check the first one later. Maybe I'm just confused about it.

For 黑,you might be able to check drawings on https://www.yellowbridge.com/chinese/dictionary.php.
I can always ask chinese or taiwanese friends about how they write it. However they don't have the same order.

from makemeahanzi.

skishore avatar skishore commented on September 26, 2024

I've checked there, Wikipedia, Arch Chinese, and a few other sites. The order from Yellow Bridge seems to be the most common one but since this radical is a part of many characters I want to be sure that I get it right.

from makemeahanzi.

GrimReaperSam avatar GrimReaperSam commented on September 26, 2024

I'll see what I can get once I'm home

from makemeahanzi.

GrimReaperSam avatar GrimReaperSam commented on September 26, 2024

Hey, I didn't find anything fixed either.

I have another request though: 蝦 doesn't exist in the dictionary.
I found that the app will give a notice that it's not found when loading the word list but when i'm learning, it will freeze at 1 word left in the session without showing anything. Usually I remove the word but I think it might be interesting for you to know.

from makemeahanzi.

GrimReaperSam avatar GrimReaperSam commented on September 26, 2024

Hi!

Another character that isn't in the dictionary: 鵝, it's used for the word penguin.
Is the inkstone database updated also?

Thanks,
Fayez

from makemeahanzi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.