Comments (3)
One potential concern that I have is that link URLs could theoretically pointing anywhere, not just at the site I originally configured. It would be nice to lock that down more tightly somehow. Perhaps having an elfeed-entry-base-url
property for feeds that gets used in place of calculating the base URL from the feed URL if configured.
from elfeed.
I looked at this a bit more today. I was thinking of changing elfeed-show-refresh--mail-style
to check if the metadata on the feed has a :entry-base-url
plist entry and use that in place of the current base computed from the feed URL if present. Would a change like this be acceptable?
I'm an elfeed-org user as well so if this change would be acceptable I'll also submit a PR to elfeed-org to allow feed metadata to be specified, probably using a property on the feed entries.
from elfeed.
Given the proposed commit I made hasn't had an enthusiastic reception I've resorted to solving this a different way for now. I used :around
advice on elfeed-compute-base
that intercepts the URL being passed in, matches against it, and allows it to be replaced. If anyone arrives here and is interested in this workaround, the advice function I defined is:
(defvar kea/elfeed-compute-base-url-rewrites nil
"List of lists of replace-regexp-in-string arguments w/o the actual string")
(defun kea/elfeed-compute-base-url-rewrite-advice (fn url)
(mapc (lambda (args)
(let ((regexp (nth 0 args))
(rep (nth 1 args))
(optargs (nthcdr 2 args)))
(setq url (apply #'replace-regexp-in-string regexp rep url optargs))))
kea/elfeed-compute-base-url-rewrites)
(funcall fn url))
For the problem reporting here I'm setting kea/elfeed-compute-base-url-rewrites
to
(setq kea/elfeed-compute-base-url-rewrites
`((,(rx line-start "http" (opt "s") "://feeds.kottke.org/")
"https://kottke.org/")))
I still think my proposed patch is a more elegant solution for this problem, but this works around the problem until there is an upstream fix without me having to maintain my fork.
from elfeed.
Related Issues (20)
- Multiple databases and elfeed-curate
- Posts marked as read keep reappearing in search HOT 1
- No error is displayed when updating feeds fails!
- Can someone give an example where elfeed-search-title-min-width actually does something? HOT 3
- A way to update feed based on feed title
- Manually changing entry date breaks search function HOT 2
- Performance issue when keys are long and similar
- Limit elfeed-search-browse-url to one URL HOT 1
- cannot update feeds HOT 1
- Set per-feed curl options
- elfeed-db-load: Wrong type argument: avl-tree-, nil with Emacs 29.3 and no upgrade HOT 3
- Where has feed meta-information gone? HOT 1
- How to clear the DB? HOT 1
- curl forbidden to access rss HOT 1
- elfeed update mkdir error on emacs 29.1 HOT 3
- Couldn't Resolve Proxy for Specific RSS Feeds
- A package for dealing with lists of remote OPML files.
- https://archlinux.org/feeds/news doesn't work HOT 2
- Debugging process for elfeed? HOT 3
- Can we support `thr:in-reply-to` tags? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elfeed.