invisible search parameters will still be considered for search about homer-ui

[nicodemus]

I have experienced the same issue, with 'source_ip' being included in the WHERE clause, with no value being specified in the GUI. Returning to the search panel and clicking 'Clear' seems to fix it.

[lmangani]

could either of you confirm if this is still an issue with the latest UI/API git version? Thanks

[mmonka]

We tested this behavior with a version from july, 26th (d61773c) today.
Bug still exists.

[lmangani]

Thanks for the update, will review. Are you loading the session with any URL parameters?

[adubovikov]

@mmonka can you please provide the JSON request ?

[boettner]

I removed the field "protocol" from the search form, but its former value is still included in the search request:

{"id":"search","param":{"to_user":"4921163555533","from_user":"4921163555533","orand":true,"proto":"tcp","limit":"1000"}}

This gets posted to: /api/v1/profile/store/search

We also saw that search values are stored in the settings database:

mysql> select * from setting where uid = 3054 and param_name = "search";
+----+------+------------+------------------------------------------------------------------------------------------------+---------------------+---------------------+------------+--------+
| id | uid  | param_name | param_value                                                                                    | valid_param_from    | valid_param_to      | param_prio | active |
+----+------+------------+------------------------------------------------------------------------------------------------+---------------------+---------------------+------------+--------+
|  7 | 3054 | search     | {"to_user":"4921163555533","from_user":"4921163555533","orand":true,"proto":"tcp","limit":"1000"} | 2012-01-01 00:00:00 | 2032-12-01 00:00:00 |         10 |      1 |
+----+------+------------+------------------------------------------------------------------------------------------------+---------------------+---------------------+------------+--------+

We would expect saved values are only considered when the form field is actually visible in the search form :-)

Hope that helps!

[adubovikov]

@boettner in the UI you have one global search object and once you created in the "FULL Search page" it will be available also for all "Quick search" widgets... If you want to clean up it, just press "Clear" and it should be done

[boettner]

Technically clear to me, but (our) users aren't expecting this behaviour.

Case:
Someone changes the "global search form" dashboard and removes a field. All other users (with pre-filled values) won't find any packets. Sure, they could press "Clear" but that's IMHO not obvious.

But I see the point. Maybe this is more an enhancement. Maybe we'll change this someday and make a pull request.

[adubovikov]

the best way IMHO, clean up the object and populate with current variables.
I will look on it later.

On 24 August 2016 at 09:58, Jonas [email protected] wrote:

Technically clear to me, but (our) users aren't expecting this behaviour.

Case:
Someone changes the "global search form" dashboard and removes a field.
All other users (with pre-filled values) won't find any packets. Sure, they
could press "Clear" but that's IMHO not obvious.

But I see the point. Maybe this is more an enhancement. Maybe we'll change
this someday and make a pull request.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#57 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AETdJQ7ckSCsei70YSdbIBzEIOxCRmKPks5qi_mwgaJpZM4HU3yq
.