LDAP Groupmembership does not work about homer-ui

[adubovikov]

in the homer 3.5 we have used also dn
https://github.com/sipcapture/homer/blob/homer3/webhomer/class/auth/ldap/auth.php

the fix:

sipcapture/homer@f522ae3

Line 72: Compat: This works for Active Directory, but might horribly break other directory services. Creating a constant in preferences called "ACTIVE_DIRECTORY" and checking that and determining whether to pass $username or $result[0]['dn'] would be better.

we can change it to a php constant variable

[adubovikov]

sipcapture/homer-api@47400c8

and

sipcapture/homer-api@29c4094

please test

[mmonka]

should be:
$result[0][LDAP_GROUP_USER][0]
^^
if (!$this->check_filegroup_membership($ds,$result[0][LDAP_GROUP_USER][0])) {

then it works!

[adubovikov]

sipcapture/homer-api@9f42f03

sipcapture/homer-api@c22c2ca

[mmonka]

That looks good for us now. But it looks like you have to put the new grp values for admins also to $_SESSION:

diff --git a/api/Authentication/LDAP.php b/api/Authentication/LDAP.php
index dff73e5..b43fc90 100644
--- a/api/Authentication/LDAP.php
+++ b/api/Authentication/LDAP.php
@@ -124,6 +124,7 @@ class LDAP extends Authentication {
if ($value == $param['username']) {
$_SESSION['userlevel'] = 1; # LDAP_ADMINLEVEL;
$user['grp'] = "users,admins";

•                           $_SESSION['grp'] = "users,admins";
                       }
                   }
                   return $user;
  

[rbott]

The pull request for this fix has already been accepted. I guess we can close this issue then :-)