Comments (5)
Changing the return type from an interface to a concrete implementation causes the incompatibility METHOD_RETURN_TYPE_CHANGED
as now source code assigning the return value to another implementation of the interface won't work any longer.
This is already detected in the first run of japicmp, but the class is package protected and therefore filtered.
If you change the configuration of japicmp to package_protected
, you will see the change in the first run:
<plugin>
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
<configuration>
<parameter>
<accessModifier>package_protected</accessModifier>
</parameter>
</configuration>
</plugin>
PS: The documentation is currently wrong, as the option is named there protected
and not package_protected
.
from japicmp.
Uh? Please help me understand: If a released version of a library contains a package private class, then that class is NOT accessible to the outside world. So how can there be a break in compatibility for clients in the next version when that class is made public, no matter what changes?
from japicmp.
You are right. When the class changes to public, all incompatibilities should be ignored.
from japicmp.
You are right. When the class changes to public, all incompatibilities should be ignored.
Ah, thank you 😄 😄
from japicmp.
Fixed with this commit.
from japicmp.
Related Issues (20)
- Filter for full annotations HOT 5
- >=0.16.0: Cannot compare versions because the number of old versions is different than the number of new versions HOT 4
- Move of method to superclass with generics METHOD_REMOVED HOT 1
- New default method detected as METHOD_NEW_DEFAULT when BinaryIncompatible disabled and SourceIncompatible enabled HOT 1
- htmlTitle not actually added to html file HOT 2
- Changing default method to static should be separate case HOT 5
- Switch to Apache Groovy HOT 1
- Maven plugin does not obey property japicmp.skip when generating reports. HOT 2
- False positive when on a final class protected method made into private HOT 1
- Regression CLASS_GENERIC_TEMPLATE_CHANGED HOT 2
- Questions about the mechanism of binary compatibility checks HOT 2
- some newer kotlin changes show up as a binary string HOT 3
- Take `transient` modifier into account
- have some sort of "warn" level HOT 1
- Do not mark class as changed in case of synthetic member
- JApiCmpArchive should support byte arrays
- Take `volatile` modifier into account
- `METHOD_RETURN_TYPE_CHANGED` reported for `package-private` method promoted to `public` that changes return type HOT 15
- Take changes to annotations into account HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from japicmp.