Comments (3)
What did you expect to happen?
A user can check if two values are both symbols, the match() should return true
I think this assumption is not quite correct. Since these are two completly different Symbol
s, this schould return false
. According to MDN even two Symbol
s with the same description are not the same (Symbol("foo") === Symbol("foo") // false
).
from samsam.
@khamiltonuk I created a PR (#127). Let's discuss how we proceed here 😄
from samsam.
This has been fixed with #127
from samsam.
Related Issues (20)
- Match.js improve error message to describe what is going on
- Proposal: Add `match.json(object)` HOT 1
- Circular dependency HOT 2
- Dependency was DELETED !! COME ON !! PLZ HELP HOT 1
- Create .d.ts from JSDoc
- deepEqual returns true for different promise instances HOT 1
- Infinite recursion on circular object when using sinon.match({})
- Error in headless Chromium HOT 1
- [Security] Lodash vulnerability
- Fix failing IE11 tests HOT 3
- Failling builds for #44 HOT 2
- Document createMatcher and match.* APIs HOT 2
- Deep equality matching broken on arrays HOT 3
- Version of lodash used is out of date HOT 8
- using deepEqual on Maps always returns true HOT 1
- deepEqual throws an exception while comparing two jQuery objects on IE-11 HOT 2
- Update version of lodash to address high severity vulnerability HOT 2
- Lodash vulnerability HOT 1
- isArgument invalid structure causing low test coverage HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from samsam.