Change forms.py to use newforms about hackzor

[GoogleCodeExporter]

Original comment by [email protected] on 10 Nov 2007 at 1:42

• Changed state: New

[GoogleCodeExporter]

Removing owner for prioritizing 

Original comment by [email protected] on 31 Jan 2008 at 12:45

[GoogleCodeExporter]

I would like to try to resolve this issue.

Original comment by [email protected] on 20 Feb 2008 at 1:58

[GoogleCodeExporter]

Assigning to Jakub

Original comment by [email protected] on 20 Feb 2008 at 6:53

• Changed state: Assigned

[GoogleCodeExporter]

Original comment by [email protected] on 21 Feb 2008 at 11:14

• Changed state: Started

[GoogleCodeExporter]

Attaching patch for this issue.

Original comment by [email protected] on 24 Feb 2008 at 9:35

Attachments:

• newforms.diff

[GoogleCodeExporter]

Hey jakub,
Is this the final version of the patch? I remember us going back and forth on a 
few
changes and I'd assumed that you had something pending.

If there's nothing pending, I'll do another review and you can submit it if all 
is ok

Original comment by [email protected] on 23 Mar 2008 at 9:33

[GoogleCodeExporter]

Sorry, I've been quite busy recently.
Unless we are migrating to Django Trunk, it's final version.

Original comment by [email protected] on 25 Mar 2008 at 9:08

[GoogleCodeExporter]

We are migrating to the trunk. More work for you :)

Original comment by [email protected] on 26 Mar 2008 at 7:10

[GoogleCodeExporter]

Patch with migration to the trunk.

Original comment by [email protected] on 26 Mar 2008 at 7:20

Attachments:

• newformstrunk.diff

[GoogleCodeExporter]

A few comments:

Why have you added slashes to the ends of urls in certain places and removed 
them in
a few other places?
Also I don't think changing this
+        (r'^opc(/|$)', include('hackzor.server.urls')),
is necessary. IIRC django should handle this automatically

Why in form.py,  User.objects.create_user rather than User(). Has the API 
changed?

Delete the __init__ function in Submit solution if you want to remove it. Don't
comment it.

Otherwise all looks ok. Great Job!

Makes changes and attach new diff if necessary.

Original comment by [email protected] on 30 Mar 2008 at 12:31

[GoogleCodeExporter]

I have altered URLs because I thought that Django trunk handles URLs more strict
(they don't work using builtin development server). My bad.

Using User() rather than User.objects.create_user would require to hash 
password by hand.

__init__ function in SubmitSolution is also my mistake.

Here's patch without URL changes and with SubmitSolution.__init__ deleted.

Original comment by [email protected] on 31 Mar 2008 at 9:51

Attachments:

• newformsfinal.diff