File entry error on opening diff view about diffview.nvim

[sindrets]

The file entry structure existed before the API, but some things were changed during that time.

The error seems to occur because the winnr is somehow invalid, which seems strange because I validate and restore the window layout if it's broken before loading buffers. What is even stranger is that the error indicates that the winnr is neither a number nor a string, but it's still able to be concatenated with the lua string in this line:

diffview.nvim/lua/diffview/file-entry.lua

Line 133 in 0589dc1

vim.cmd(winnr .. "windo filetype detect")

This is very difficult to fix without a reproducible scenario, it would be very helpful if you could provide a tarball of a git repo and a commit SHA where this happens.

Otherwise could you at least show the output after you get the error, having applied this patch:

diff --git a/lua/diffview/file-entry.lua b/lua/diffview/file-entry.lua
index 67fca87..246b3ae 100644
--- a/lua/diffview/file-entry.lua
+++ b/lua/diffview/file-entry.lua
@@ -130,6 +130,7 @@ function FileEntry:load_buffers(git_root, left_winid, right_winid)
         table.insert(self.created_bufs, bn)
         a.nvim_win_set_buf(split.winid, bn)
         split.bufid = bn
+        print(vim.inspect(winnr), split.winid, a.nvim_win_is_valid(split.winid), vim.inspect(a.nvim_tabpage_list_wins(0)))
         vim.cmd(winnr .. "windo filetype detect")
       end

This might at least help figure out what's going on with the winnr.

[akinsho]

@sindrets will try and get the output for you 👍🏾 it could very well be something strange on my system or config since it seemed to happen regardless of the repository. But I'll dig in and feedback.

[akinsho]

Not sure if this was spurious or due to some config changes I made on my system or what but I haven't been able to reproduce this so I'm going to close this for now as a fluke. If it recurs I'll post back here but it hasn't so far (I mess around with my config a lot so could very easily have been something I did)