Coder Social home page Coder Social logo

Comments (6)

sindresorhus avatar sindresorhus commented on May 22, 2024 1

It types the response as strict as it possibly can without knowing anything about it other than that it's JSON. For example, json.a could be null, in which case, json.a.b would not exist.

from type-fest.

sindresorhus avatar sindresorhus commented on May 22, 2024 1

I think we should document in the type that it's not meant as a response type, but rather to make certain input strict.

It could maybe also be useful as a super-type for response types. So you do CustomResponseType extends JsonObject { … } to ensure you don't accidentally use non-JSON compatible types. Thoughts?

from type-fest.

fregante avatar fregante commented on May 22, 2024

json.a could be null, in which case, json.a.b would not exist

GraphQL guarantees that already, if you check for json.errors first.

How am I gonna type this without // @ts-ignore and node: any? 😰

let authors: Author[] = json.repository.pullRequest.commits.nodes
	.map(node => node.commit.author); // from Refined GitHub

from type-fest.

BendingBender avatar BendingBender commented on May 22, 2024

I think this type is useful for APIs that want to accept only JSON-like structures, it is not really useful as a response type. There you usually have an idea of how a response is structured.

For your specific example, how should TS know something about the semantics of GraphQL? If you already know the shape of your response, why do you want to use JSONObject?

from type-fest.

fregante avatar fregante commented on May 22, 2024

It seemed to make sense that a fetchApi would return a JsonObject, but it's hard to even cast that as something else (see as UserInfo in the commit above) because each level "could be string or null", so in most cases you'd have to cast as unknown as UserInfo at best, which means JsonObject is lost instantly.

In the specific case I'm ok with the code throwing if a level isn't there, so the error isn't swallowed by some if levelX !== undefined, hence the as any.

I understand why TS throws, but I don't know how/if it can be used in this case.

from type-fest.

BendingBender avatar BendingBender commented on May 22, 2024

I think it just doesn't meant to be used like this. This is only useful for APIs like JSON.stringify and the like.

from type-fest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.