Coder Social home page Coder Social logo

Comments (3)

jdmarshall avatar jdmarshall commented on August 13, 2024 1

I was just trying to write a test and was surprised to find that my retry was taking almost exactly 1000 ms longer than I expected.

I don't think trying to adding an explicit delay to the onFailedAttempt() is the correct solution here. I think documenting the options pass-through to retry is the correct strategy. For instance:

pRetry(myFunction, { retries: 2, minTimeout: timeout, factor: 1 })

from p-retry.

sindresorhus avatar sindresorhus commented on August 13, 2024

Thanks for commenting. That's a good point. I've improved the example now.

from p-retry.

jdmarshall avatar jdmarshall commented on August 13, 2024

Additionally, because the retry module is not using arrow functions, it ends up rebinding 'this', which I didn't notice in my initial implementation, and so my delay function was getting undefined as an argument.

The way I'm suggesting avoids that problem, but you might want to work that into any other examples, if for no other reason to signal to people "hey this bit is tricky".

from p-retry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.