Comments (9)
@kainiedziela the project's structure has changed since the PR was opened, so it's slightly outdated, I'll revisit the PR and update it tomorrow.
from ow.
From #71 (comment)
When I started implementing not, I was thinking about rephrasing messages automatically. I thought, If I always use
to be
, we could change thatto not be
. But then I had error messages where I couldn't useto be
. So if we want clean messages fornot
, we might want to add aninvertedMessage
property to the validation object.
from ow.
I think we can automate most of it by creating helpers for the most common cases, like to be
, and support an invertedMessage
option for the few cases we can't automate.
Expected
bar
to be of typestring
but received typenumber
Could be automated to something like:
expectToBeOfType('bar', 'string', 'number');
from ow.
Good idea! I'll take a look when I find some time.
from ow.
@SamVerschueren @sindresorhus Can you help getting me started here. i want to start my first OS contribution.
from ow.
@issuehuntfest has funded $60.00 to this issue. See it on IssueHunt
from ow.
AFAIU in almost all cases it's enough to just put not
after the first to
, like Expected 'value' to not be/have/match ...
, and for the cases where this approach won't work, e.g. min/max length, we can add invertedMessage
, right? If so, I'm halfway there 🙂
from ow.
Any further work being done on this issue? The proposed PR doesn't pass tests. I'm inclined to pick this up.
from ow.
@sindresorhus has rewarded $54.00 to @alexnoz. See it on IssueHunt
💰 Total deposit: $60.00- 🎉 Repository reward(0%): $0.00
🔧 Service fee(10%): $6.00
from ow.
Related Issues (20)
- Bug: `isValid` wrong typing HOT 3
- Package does not seem to work on node v8 `SyntaxError: Unexpected token {` HOT 1
- string.nonBlank validator HOT 1
- Error running with metro bundler
- generate objects from predicate HOT 3
- use browser-side HOT 1
- Unclear error message when checking NaN against the number type HOT 7
- Composition HOT 3
- Is there a way for an object predicate to differentiate between key with value `undefined`, and key not present? HOT 2
- should `ow.string.equals` be narrowing the type to specific strings? HOT 1
- wrong message: Expected `e` to be of type .... - instead of Expected argument to be of type HOT 3
- Show all possible errors exhaustively (option?)
- const values HOT 1
- Q: how to make custom type narrowing validator (i.e. Predicate<x>)? HOT 3
- metadata
- Documentation is 404
- Build errors when using ow in React app compiled with vite
- Upgrading to 1.1.0 from older version makes TS complain HOT 6
- correct pattern for optional 'required' properties?
- Cannot find module 'ow' or its corresponding type declarations HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ow.