Coder Social home page Coder Social logo

Comments (2)

sindresorhus avatar sindresorhus commented on July 1, 2024

Does 404 work? What environment are you running in? Native Fetch or node-fetch?

We have a test to confirm it's working:

ky/test/hooks.ts

Lines 610 to 640 in 2d56baf

test('runs beforeError before throwing HTTPError', async t => {
const server = await createHttpTestServer();
server.post('/', (_request, response) => {
response.status(500).send();
});
await t.throwsAsync(
ky.post(server.url, {
hooks: {
beforeError: [
(error: HTTPError) => {
const {response} = error;
if (response?.body) {
error.name = 'GitHubError';
error.message = `${response.statusText} --- (${response.status})`.trim();
}
return error;
},
],
},
}),
{
name: 'GitHubError',
message: 'Internal Server Error --- (500)',
},
);
await server.close();
});

from ky.

geoff-harper avatar geoff-harper commented on July 1, 2024

It's in native fetch and 404 is working. I can't imagine it would make a difference but I'm noticing it on a PUT req. I've also checked it on Firefox and Chrome. Its options req is 200, I can't remember if it's the same outcome when an options req is 500

from ky.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.