Hostname option interferes with grunt-contrib-watch about grunt-php

[sindresorhus]

How do you inject the Livereload snippet?

https://github.com/gruntjs/grunt-contrib-watch#enabling-live-reload-in-your-html

It has to match whatever you change your hostname too.

[brodkin]

@sindresorhus I'm using the browser extension, but I can tell that it's a server issue not a client issue.

If I run grunt:watch directly I can navigate to http://localhost:35729/ and it works just fine. If I run my task that starts grunt-php first then navigating to that same address fails.

[sindresorhus]

Can you share the relevant part of your Gruntfile?

[brodkin]

Sure!

my dev task

grunt.registerTask('dev', [
'php:watch',
'watch'
]);

grunt-php

php: {
  watch: {
    options: {
      hostname: '0.0.0.0',
      port: 8000,
      base: 'public',
      router: path.resolve('server.php')
    }
  }
},

grunt-contrib-watch has nothing fancy--just livereload: true is set.

I can take this exact configuration and set the hostname to localhost and it will suddenly work.

[brodkin]

Ykw? I thought it was just livereload not working. I hadn't realized that the watch task never gets fired at all. The behavior is almost as if keepalive had been set to true.

[brodkin]

I think the issue is on line 14 of php.js. When checking for a server start the hostname is passed directly to http.request and while 0.0.0.0 is an acceptable value for the PHP built-in server, Node cannot resolve it. Interpreting an ip of 0.0.0.0 as localhost would probably fix this issue. I've never written or contributed to a grunt task before, but I can try to test this and write a fix.