Coder Social home page Coder Social logo

Comments (11)

nfrasser avatar nfrasser commented on August 19, 2024

I'm getting a similar problem using grunt-php with Travis:
Screenshot

It falls into an infinite loop of 500 errors and is never able to move to the next Grunt task. Works fine locally though. Also not sure if this is a grunt-php bug, or a Travis configuration issue. Edit: It was a Travis configuration issue.

from grunt-php.

brandom avatar brandom commented on August 19, 2024

Same issue here, not using Travis.

OS X 10.9.1, latest grunt and grunt-php.

from grunt-php.

franz-josef-kaiser avatar franz-josef-kaiser commented on August 19, 2024

Sadly I got exactly the same problem. Was running for month w/o any problem, but not this time. Funny thing is, that it still does run and display the local site propery. For whatever reason.

from grunt-php.

feryardiant avatar feryardiant commented on August 19, 2024

Me too, I have no problem since the first time I use it, but not today (I still can use it yesterday)

grunt-php

and this is my Gruntfile.js:

module.exports = function(grunt) {
  'use strict';

  grunt.initConfig({
    php: {
      server: {
        options: {
          port: 8088,
          open: true
        }
      }
    },

    // Other grunt task here

    watch: {
      options: {
        nospawn: true,
        livereload: true
      },
      backend: {
        files: '<%= phplint.backend %>',
        tasks: 'phptest'
      },
      // Some other Less & JS watcher here
    }

  });

  grunt.registerTask('default', ['php:server', 'watch']);
}

from grunt-php.

nfrasser avatar nfrasser commented on August 19, 2024

@feryardiant Looks like your PHP script does a 302 redirect immediately upon hitting /, which could be messing up this plugin. Maybe try configuring it to return a 200 instead?

from grunt-php.

feryardiant avatar feryardiant commented on August 19, 2024

Yes! you're right @nfrasser.
but, I still wondering why it could be messed up with redirection at the first run but not when it has been running?

I hope you know what I meant.

from grunt-php.

nfrasser avatar nfrasser commented on August 19, 2024

https://github.com/sindresorhus/grunt-php/blob/v0.4.0/tasks/php.js#L17-L21
Upon connecting this plugin calls the checkServer function, which recursively calls itself until the server returns a status other than one of 200, 404, or 301.

Potential fix could be checking that the status code is in the 200-499 range instead?

from grunt-php.

sindresorhus avatar sindresorhus commented on August 19, 2024

which recursively calls itself until the server returns a status other than 200, 404, or 301.

Not "other than". It stops checking after it get either 200, 404, or 301. This it to make sure the server is started before it continues as the following task might depend on it.

from grunt-php.

nfrasser avatar nfrasser commented on August 19, 2024

Whoops yeah that's what I meant

from grunt-php.

brodkin avatar brodkin commented on August 19, 2024

As an update to what @sindresorhus had said, a recently merged PR (d8508d6) will now accept any 200, 300, or 400-level response, not just the three previously mentioned. Because 500-level errors indicate an error state they are not accepted as a valid state in which the script can continue to execute.

@sindresorhus It might be wise to throw an error in grunt if the callback check fails too many times. What do you think?

from grunt-php.

sindresorhus avatar sindresorhus commented on August 19, 2024

It might be wise to throw an error in grunt if the callback check fails too many times. What do you think?

Sure

from grunt-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.