Requesting a relative path (in browser) about got

[lukehorvat]

Happy to report that as of stream-http v1.6.0, relative paths work when using got in the browser. 💪

[sindresorhus]

Yeah, that seems like a bug in https://github.com/sindresorhus/prepend-http Will fix.

I didn't realize got works in the browser through browserify. That's awesome! I assume browserify shims the http module using XHR.

[arthurvr]

I didn't realize got works in the browser through browserify.

I didn't eighter. Super cool! If we can confirm everything works fine I'd even say that's a welcome addition to the readme?

[sindresorhus]

Definitely!

[kevva]

@sindresorhus, they recently added better support for streams too for browsers that supports it. https://github.com/substack/node-browserify/blob/master/changelog.markdown#1100.

[sindresorhus]

@lukehorvat Should be fixed now. Try reinstalling got ;)

[floatdrop]

This is relevant to - mdlavin/nested-error-stacks#6

[lukehorvat]

Thank you @sindresorhus. 💃

[lukehorvat]

Just having a play around with it now. It seems to send the request to http://localhost:8000./ping, which still isn't correct, but is close. It looks like http-browserify is the cause of the problem this time, so I will open an issue in that repo.

[sindresorhus]

@lukehorvat Alright, paste in the link to the issue when you do so we can follow along.

[lukehorvat]

@sindresorhus Okay, I've opened an issue here with an accompanying PR. Unfortunately there are 31 other pending PRs so I don't think it's going to get merged any time soon. 😐

[bendrucker]

http-browserify was replaced by https://github.com/jhiesey/stream-http in browserify@11

[bendrucker]

Also I'm gonna bring in @floatdrop's captureStackTrace ponyfill to nested-error-stacks in mdlavin/nested-error-stacks#6 instead of the naive initial solution I proposed. Right now got's not really compatible with browserify (b/c nested-error-stacks isn't). It'll work in Chrome, but any errors will result in an exception in a non-V8 browser (IE, Safari, Firefox).