Comments (7)
Should we set agent to false by default as well? This seems like not obvious behaviour, but 5 sockets limit bothers me a lot.
from got.
At first thought I would be against but if @substack does it⦠:p
from got.
Yes, as long as we document it. I think it's fixed in Node 0.11 though.
from got.
@sindresorhus yes - this is fixed in 0.11.x. I would wait for release for some time, instead of setting default agent to false (it also breaks https tests) now and revert it back.
from got.
Node 0.10 will still be have to supported for a long time after (or if ever) node 0.12 is released. I think we should do it.
from got.
Having the same behavior on Node 0.10 & 0.12 is reason enough to do it.
from got.
To track progress on this:
Setting agent: false
breaks https requests - https://github.com/substack/hyperquest/issues/19
There is another approach to this (see here) - setting maxSockets to Infinity
(like 0.11 node does - nodejs/node-v0.x-archive@9fc9b87#diff-5f7fb0850412c6be189faeddea6c5359R100):
opts.maxSockets = opts.maxSockets || Infinity;
// ...
var fn;
if (parsedUrl.protocol === 'https:') {
fn = https;
opts.agent = new https.Agent(opts);
} else {
fn = http;
opts.agent = new http.Agent(opts);
}
But this will leave connections in pool - so redirect test will not be completed.
from got.
Related Issues (20)
- `Response<string>` returned rather than a json response HOT 2
- Is v13 still maintained/supported? HOT 1
- Hangs on revalidated response from cache
- Infinite redirection with special characters in the redirected URL HOT 1
- Support `servername` https option
- How to get traffic usage per request? HOT 1
- Is it possible to skip/disable normalization of a request body? HOT 1
- afterResponse fired 3 times on error HOT 3
- Getting the IP address for failed requests due to timeout
- Post request to API returns response code 500 (Internal Server Error) whereas CURL returns 200 status code HOT 2
- Timeouts are longer than expected HOT 1
- NPM Says: Types are not integrated HOT 1
- FormData getLength can error out when some file input is unknown stream.
- POSTs whose bodys are instances of createReadStream hang with latest node HOT 5
- Apply `applyDestroyPatch` for v11.x
- Stream report downloadProgress when redirects HOT 1
- Is TypeScript support outdated? HOT 1
- Good News for CJS
- afterResponse hook is not called after a retryWithMergedOptions() HOT 2
- HTTP2 with proxy doesn't work? (http2-wrapper)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from got.